DO NOT MERGE rabbitmq_shovel: delay closing amqp10 source connection#15603
Draft
DO NOT MERGE rabbitmq_shovel: delay closing amqp10 source connection#15603
Conversation
When using an autodelete shovel, acks to source might still be in-flight when the connections start to close. Let's give them a short buffer to finish sending acks and then close.
dcorbacho
force-pushed
the
shovel-close-conn-flake
branch
from
bf2a896 to
6be77f9
Compare
ansd
reviewed
Mar 13, 2026
Comment on lines
-394
to
+403
| _ = amqp10_client:end_session(Sess), | ||
| _ = amqp10_client:close_connection(Conn), | ||
| %% Wait for pending acks/nacks to be delivered | ||
| _ = timer:apply_after(10_000, ?MODULE, connection_close, [Conn, Sess]), | ||
| ok; | ||
| close_source(_Config) -> ok. | ||
|
|
||
| connection_close(Conn, Sess) -> | ||
| _ = amqp10_client:end_session(Sess), | ||
| _ = amqp10_client:close_connection(Conn). | ||
|
|
Member
There was a problem hiding this comment.
The link should be detached first.
Member
There was a problem hiding this comment.
Detaching the link will cause acks to be delivered to the quorum queue before the quorum queue removes the consumer:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using an autodelete shovel, acks to source might still be in-flight when the connections start to close. Let's give them a short buffer to finish sending acks and then close.
shovel_dynamic_SUITE:autodelete_classic_on_publish_with_rejections/1often flakes in CI because of this