Eliminate a flake in rabbit_fifo_dlx_integration_SUITE#15692
Merged
michaelklishin merged 2 commits intomainfrom Mar 11, 2026
Merged
Eliminate a flake in rabbit_fifo_dlx_integration_SUITE#15692michaelklishin merged 2 commits intomainfrom
rabbit_fifo_dlx_integration_SUITE#15692michaelklishin merged 2 commits intomainfrom
Conversation
Killing a Ra member transfers leadership most of the time but not all of the time: the same node can be re-elected. If the purpose of the test is to transfer leadership and observe a certain DLX worker behavior, why not transfer leadership to a specific node instead?
michaelklishin
changed the title
rabbit_fifo_dlx_integration_SUITE
Member
|
If I remember correctly, the purpose was first stopping a node gracefully The same test case also flakes for another reason: #15548 (comment) |
Collaborator
Author
|
@ansd if the idea in the test is to specifically kill a member, then Otherwise transferring leadership cleanly makes more sense to me. I have pushed a change that adopts |
michaelklishin
added a commit
that referenced
this pull request
Mar 11, 2026
Eliminate a flake in `rabbit_fifo_dlx_integration_SUITE` (backport #15692)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Killing a Ra member transfers leadership most of the time but not all of the time: the same node can be re-elected.
If the purpose of the test is to transfer leadership and observe a certain DLX worker behavior, why not transfer leadership to a specific node instead?