Handle stream SAC monitors in SAC coordinator#15695
Draft
acogoluegnes wants to merge 1 commit intomainfrom
Draft
Handle stream SAC monitors in SAC coordinator#15695acogoluegnes wants to merge 1 commit intomainfrom
acogoluegnes wants to merge 1 commit intomainfrom
Conversation
acogoluegnes
force-pushed
the
stream-sac-monitors-in-sac-coordinator
branch
from
bd5a38e to
d6c0833
Compare
acogoluegnes
force-pushed
the
stream-sac-monitors-in-sac-coordinator
branch
from
d6c0833 to
1fb98a4
Compare
The stream SAC coordinator already keeps track of its monitors but delegates some of the work to the stream coordinator (in its monitors map). This commit changes this to let the SAC coordinator handle its monitors itself. This decouples the 2 coordinators. This also fixes a bug whereby the SAC coordinator would correctly re-issue monitors but would not modify the monitors map accordingly. The SAC coordinator would not then be notified of the corresponding down messages. References rabbitmq/rabbitmq-stream-dotnet-client#447
acogoluegnes
force-pushed
the
stream-sac-monitors-in-sac-coordinator
branch
from
1fb98a4 to
49ff2e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The stream SAC coordinator already keeps track of its monitors but delegates some of the work to the stream coordinator (in its monitors map).
This commit changes this to let the SAC coordinator handle its monitors itself. This decouples the 2 coordinators. This also fixes a bug whereby the SAC coordinator would correctly re-issue monitors but would not modify the monitors map accordingly. The SAC coordinator would not then be notified of the corresponding down messages.
References rabbitmq/rabbitmq-stream-dotnet-client#447