rabbitmq_management: Fix issue with oauth2+basic_auth#15793
rabbitmq_management: Fix issue with oauth2+basic_auth#15793michaelklishin merged 12 commits intomainfrom
Conversation
the user logged in via basic auth and on page reload, the credentials were deleted.
It is quietly ignored but considered to be a poor practice.
michaelklishin
left a comment
There was a problem hiding this comment.
@MarcialRosales this looks good, I have corrected a few small things.
I have one remaining question: wher should IDP_TOKEN_ENDPOINT that fakeproxy uses come from? Nothing, including the workflows, seems to be setting that value.
Am I missing something?
|
The test suite that runs idp initiated login via a proxy is https://github.com/rabbitmq/rabbitmq-server/blob/fix-oauth2-basic-auth-reload/selenium/suites/authnz-mgt/oauth-idp-initiated-with-uaa-via-proxy.sh That file declares the configuration directory ( That generated .env file is then sourced by all bootstrapping scripts — for RabbitMQ itself, for dependencies like |
… any kind of use
rabbitmq_management: Fix issue with oauth2+basic_auth (backport #15793)
Proposed Changes
Fix: OAuth2 + basic auth — basic-auth users lost stored credentials on reload
Types of Changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply.You can also fill these out after creating the PR.
This is simply a reminder of what we are going to look for before merging your code.
CONTRIBUTING.mddocumentFurther Comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution
you did and what alternatives you considered, etc.