Performance improvement on unconfirmed map #374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gabriele Santomaggio <[email protected]>
Signed-off-by: Gabriele Santomaggio <[email protected]>
after removed from the server Signed-off-by: Gabriele Santomaggio <[email protected]>
Signed-off-by: Gabriele Santomaggio <[email protected]>
The test that needs reconnection sometimes exceeded the 2m timeout.
…ver been sent to rabbitmq
Gsantomaggio
approved these changes
Jan 20, 2025
There was a problem hiding this comment.
tested also with reliable_client.go with a cluster. Everything is ok ! Thank you @hiimjako
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a sub-branch of check_close_during_send, so please ensure that PR #372 is merged first.
This PR introduces performance improvements by leveraging slice preallocation and reducing the average size of the unConfirmed map, which now only stores the currently in-flight messages.
Note: Additionally, I identified the root cause of the performance degradation observed in the client under high traffic or client reconnections in cloud environments. This issue appears to be related to Issue #293 and is associated with the default TCP socket settings. I suspect this is OS-related, as it manifests on Linux (tested on an AWS cluster with ARM64 nodes running Linux). Again this was solved setting in the stream
SetWriteBuffer(-1)andSetReadBuffer(-1).