Skip to content

Reuse the locator connection #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 8, 2025
Merged

Reuse the locator connection #388

merged 8 commits into from
Apr 8, 2025

Conversation

Gsantomaggio
Copy link
Member

@Gsantomaggio Gsantomaggio commented Apr 2, 2025

  • Reuse the locator connection. In this PR, the locator connection is always open ( like most other clients ) and can be reused. It is useful when API like storeOffset or queryOffest are often called. The maybeReconnectLocator function reconnects the locator if/when needed ( in case of network problem|)
  • Remove one heartbeat Ticket.
  • Fix an edge case during reconnection when the metadata fails
  • closes Reuse the locator connection #387
  • Fix a race condition for producer and consumer during the internal close. The internal close now has a cleanUp function

Signed-off-by: Gabriele Santomaggio <[email protected]>
Signed-off-by: Gabriele Santomaggio <[email protected]>
Signed-off-by: Gabriele Santomaggio <[email protected]>
add condition for the restart

Signed-off-by: Gabriele Santomaggio <[email protected]>
Signed-off-by: Gabriele Santomaggio <[email protected]>
@Gsantomaggio Gsantomaggio requested a review from hiimjako April 7, 2025 07:26
Signed-off-by: Gabriele Santomaggio <[email protected]>
@Gsantomaggio Gsantomaggio marked this pull request as ready for review April 7, 2025 08:04
@Gsantomaggio Gsantomaggio changed the title resue the locator connection Reuse the locator connection Apr 7, 2025
hiimjako
hiimjako previously approved these changes Apr 8, 2025
Co-authored-by: Alberto Moretti <[email protected]>
Signed-off-by: Gabriele Santomaggio <[email protected]>
@Gsantomaggio Gsantomaggio merged commit 40d8931 into main Apr 8, 2025
4 checks passed
@Gsantomaggio Gsantomaggio deleted the reuse_locator branch April 8, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reuse the locator connection
2 participants