Fix handling and storing offset by timestamp #392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: Sometimes the timestamp value can be written as an offset in rabbitmq, which freezes message consumption Real case: You add a new consumer to an existing stream for which the offset is not yet set, and you do not want to reread all messages, so you specify -1 min. If there are no messages for a certain time and automatic flush is triggered, this timestamp value will be written as the offset.
|
It makes sense to me, it was clearly a bug. |
hiimjako
approved these changes
May 7, 2025
Gsantomaggio
approved these changes
May 7, 2025
|
Thank you @yurahaid |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Sometimes the timestamp value can be written as an offset in rabbitmq, which freezes message consumption.
Real case: You add a new consumer to an existing stream for which the offset is not yet set. You do not want to reread all messages, so you specify -1 min. If there are no messages for a certain time and automatic flush is triggered, this timestamp value will be written as the offset.
As a summary, based on the code in the library and the stream protocol, it looks like the method
consumer.setCurrentOffsetshould only be called with a typeOffset value.