Move River 2 to controls system, fix missing remaining time sensors and fix DC Charging Max Amps control#353
Merged
Conversation
GnoX
force-pushed
the
feat/river2-controls-migration
branch
from
143357c to
16f9808
Compare
GnoX
force-pushed
the
feat/river2-controls-migration
branch
from
16f9808 to
69f52d7
Compare
GnoX
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates the River 2 family (River 2 / 2 Pro / 2 Max) to the
@controlsdecorator system, fixes a field-naming bug that prevented the charge/discharge time sensors from being created and fixes DC Charging Max Amps control sending incorrect payload.Resolves #352 and #333