Fix AC sensors stuck unavailable while AC output is off for River 2 and Delta 2#361
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a followup of #356 - in there, we only updated switch, but all other fields are also unavailable so this PR adds a functionality that allows setting defaults for all fields. This also addresses a comment in #351 (comment) that reported this issue happens for River 2.
This adds a small, generic mechanism rather than patching one field. A field can declare its off value with
Field.default_when_missing(value). When a device has any such field,DeviceBaseschedules a one-shot fallback after authentication (MISSING_DEFAULT_GRACE = 10s): for each marked field that is still unset once the grace period elapses, it applies the declared value throughnotify_field. A real message arriving at any point - before or after - still wins. The field iteration and aTypeIsguard live onUpdatableProps(is_props/fields_with_missing_default), soDeviceBasenever reaches into props internals.Config / spec fields (configured charge speed, rated power, etc.) are deliberately left unmarked - an empty inverter reading should not clobber a setpoint to
0, so those stay unavailable until the device actually reports them.