Use hass config retry instead of native reconnect logic, improve error handling#50
Merged
Merged
Conversation
Owner
|
Thank you! Will quickly check how it's working on my setup and will approve. |
rabits
approved these changes
Jun 30, 2025
Owner
rabits
left a comment
There was a problem hiding this comment.
Looks good. Works for me and defaulting to update per 10 sec is necessary. Geeks will find out how to get immediate updates, but for regular user once per 10 sec sounds reasonable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds multiple changes:
disconnectedwas called more than once which caused multiple reconnect tasks to be spawned at once. If this repeats several times, requests would overlap and device received messages in wrong order causing it to immediately disconnect. This spawned yet more reconnect tasks and existing messages would still be received on the same characteristic but client would not be connected. This would explain what was was happening in [Bug]: Error Logging Loop / Disk Space Usage #36.