Pull request? #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Included documentation for this function
Documentation added to function create_hist_dens
Documentation added to function plot.hist_dens
Some extra examples and information was launching on startup and is now included in the Roxygen documentation.
Information now included in Roxygen documentation.
Introduced a start up message when loading the package into R
Removed extra examples, information and checks which are now included in the ROxygen documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Rachel,
I've made some additions and changes on a fork I created and would like to add them to the original repository if possible. I've taken out some info on my fork, if you think Osi needs them I think you can decline the pull requests and I can put them back in? Unsure.
Thanks, Conor