Move some HtDP (test engine) tests to racket/htdp#808
Draft
shhyou wants to merge 2 commits intoracket:masterfrom
Draft
Move some HtDP (test engine) tests to racket/htdp#808shhyou wants to merge 2 commits intoracket:masterfrom
shhyou wants to merge 2 commits intoracket:masterfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Resyntax analyzed 0 files in this pull request and found no issues.
Member
|
Ah, shoot! I was just fixing the module-lang tests this morning and should have read this PR first! My mistake. I'll adjust. |
Contributor
|
Why are we moving these tests? |
Collaborator
Author
|
@mfelleisen The moved tests are mainly affected by HtDP updates, so I think it would be better if HtDP CI runs them. Right now, DrDr is the only place that runs all of them, and these HtDP tests aren't checked by Github CI in racket/htdp. |
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It'd help to run the test-engine tests with CI whenever Test Engine is updated in racket/htdp, plus there are quite a few HtDP tests in module-lang-tests.rkt. This PR moves them to racket/htdp.