Skip to content

Remove unnecessary xref sorting on every query #25746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
trufae wants to merge 2 commits into
base: master
Choose a base branch
from
+40 −43
Open

Remove unnecessary xref sorting on every query #25746

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2742d85
Remove unnecessary xref sorting on every query ##analysis
claude Apr 7, 2026
2d36f57
af
radare Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions libr/anal/xrefs.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,6 @@ R_API RVecAnalRef *r_anal_refs_get(RAnal *anal, ut64 from) {
return NULL;
}

RVecAnalRef_sort (anal_refs, compare_ref); // XXX not needed?
return anal_refs;
}

Expand All @@ -339,7 +338,6 @@ R_API RVecAnalRef *r_anal_xrefs_get(RAnal *anal, ut64 to) {
return NULL;
}

RVecAnalRef_sort (anal_refs, compare_ref); // XXX not needed?
return anal_refs;
}

Expand All @@ -352,7 +350,6 @@ R_API RVecAnalRef *r_anal_xrefs_get_from(RAnal *anal, ut64 to) {
return NULL;
}

RVecAnalRef_sort (anal_refs, compare_ref); // XXX not needed?
return anal_refs;
}

Expand Down
64 changes: 32 additions & 32 deletions test/db/cmd/cmd_af
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,47 +33,47 @@ af
axf@0x100001308
EOF
EXPECT=<<EOF
CODE 0x1000012dc case.0x100001308.50
CODE 0x10000130a case.0x100001308.49
CODE 0x100001321 case.0x100001308.114
CODE 0x10000132a case.0x100001308.120
CODE 0x100001347 case.0x100001308.118
CODE 0x100001353 case.0x100001308.99
CODE 0x100001370 case.0x100001308.102
CODE 0x100001392 case.0x100001308.97
CODE 0x100001396 case.0x100001308.65
CODE 0x1000013a2 case.0x100001308.84
CODE 0x1000013b1 case.0x100001308.107
CODE 0x1000013bd case.0x100001308.115
CODE 0x1000013cc case.0x100001308.76
CODE 0x1000013fb case.0x100001308.104
CODE 0x10000140a case.0x100001308.80
CODE 0x10000141a case.0x100001308.110
CODE 0x1000014df case.0x100001308.113
CODE 0x10000143f case.0x100001308.108
CODE 0x1000015ac case.0x100001308.71
CODE 0x10000162a case.0x100001308.116
CODE 0x100001645 case.0x100001308.109
CODE 0x10000144b case.0x100001308.103
CODE 0x100001473 case.0x100001308.83
CODE 0x10000147f case.0x100001308.100
CODE 0x1000013cc case.0x100001308.76
CODE 0x10000160d case.0x100001308.98
CODE 0x100001519 case.0x100001308.82
CODE 0x100001682 case.default.0x100001308
CODE 0x100001492 case.0x100001308.111
CODE 0x1000014d0 case.0x100001308.79
CODE 0x1000014df case.0x100001308.113
CODE 0x1000014f0 case.0x100001308.64
CODE 0x100001392 case.0x100001308.97
CODE 0x1000014ff case.0x100001308.67
CODE 0x100001519 case.0x100001308.82
CODE 0x10000147f case.0x100001308.100
CODE 0x100001636 case.0x100001308.101
CODE 0x100001583 case.0x100001308.85
CODE 0x100001473 case.0x100001308.83
CODE 0x10000140a case.0x100001308.80
CODE 0x10000141a case.0x100001308.110
CODE 0x100001321 case.0x100001308.114
CODE 0x100001525 case.0x100001308.70
CODE 0x1000015f7 case.0x100001308.112
CODE 0x100001665 case.0x100001308.117
CODE 0x100001396 case.0x100001308.65
CODE 0x1000013fb case.0x100001308.104
CODE 0x1000013b1 case.0x100001308.107
CODE 0x1000014f0 case.0x100001308.64
CODE 0x100001370 case.0x100001308.102
CODE 0x1000013a2 case.0x100001308.84
CODE 0x1000013bd case.0x100001308.115
CODE 0x10000130a case.0x100001308.49
CODE 0x1000015c9 case.0x100001308.72
CODE 0x100001353 case.0x100001308.99
CODE 0x10000132a case.0x100001308.120
CODE 0x10000153e case.0x100001308.66
CODE 0x1000015a0 case.0x100001308.87
CODE 0x10000155b case.0x100001308.105
CODE 0x1000012dc case.0x100001308.50
CODE 0x100001347 case.0x100001308.118
CODE 0x10000156a case.0x100001308.119
CODE 0x100001583 case.0x100001308.85
CODE 0x1000015a0 case.0x100001308.87
CODE 0x1000015ac case.0x100001308.71
CODE 0x1000015c9 case.0x100001308.72
CODE 0x1000015f7 case.0x100001308.112
CODE 0x10000160d case.0x100001308.98
CODE 0x10000162a case.0x100001308.116
CODE 0x100001636 case.0x100001308.101
CODE 0x100001645 case.0x100001308.109
CODE 0x100001665 case.0x100001308.117
CODE 0x100001682 case.default.0x100001308
EOF
RUN

Expand Down
16 changes: 8 additions & 8 deletions test/db/cmd/cmd_ag
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,9 +93,9 @@ node [fillcolor=white, style=filled shape=box fontsize="8" fontname="Courier"];
5 [URL="0x00000833", color="lightgray", label="0x00000833"]
5 -> 4
6 [URL="sym.imp.strlen", color="lightgray", label="sym.imp.strlen"]
7 [URL="0x000007cf", color="lightgray", label="0x000007cf"]
7 [URL="0x000007de", color="lightgray", label="0x000007de"]
7 -> 6
8 [URL="0x000007de", color="lightgray", label="0x000007de"]
8 [URL="0x000007cf", color="lightgray", label="0x000007cf"]
8 -> 6
9 [URL="sym.imp.malloc", color="lightgray", label="sym.imp.malloc"]
10 [URL="0x000007f6", color="lightgray", label="0x000007f6"]
Expand Down Expand Up @@ -142,11 +142,11 @@ directed 1
]
node [
id 7
label "0x000007cf"
label "0x000007de"
]
node [
id 8
label "0x000007de"
label "0x000007cf"
]
node [
id 9
Expand Down Expand Up @@ -205,13 +205,13 @@ directed 1
target 13
]
]
{"nodes":[{"id":0,"title":"sym.imp.free","offset":1584,"out_nodes":[]},{"id":1,"title":"0x0000083f","offset":2111,"out_nodes":[0]},{"id":2,"title":"sym.imp.strcpy","offset":1600,"out_nodes":[]},{"id":3,"title":"0x00000814","offset":2068,"out_nodes":[2]},{"id":4,"title":"sym.imp.puts","offset":1616,"out_nodes":[]},{"id":5,"title":"0x00000833","offset":2099,"out_nodes":[4]},{"id":6,"title":"sym.imp.strlen","offset":1632,"out_nodes":[]},{"id":7,"title":"0x000007cf","offset":1999,"out_nodes":[6]},{"id":8,"title":"0x000007de","offset":2014,"out_nodes":[6]},{"id":9,"title":"sym.imp.malloc","offset":1648,"out_nodes":[]},{"id":10,"title":"0x000007f6","offset":2038,"out_nodes":[9]},{"id":11,"title":"sym.imp.strcat","offset":1664,"out_nodes":[]},{"id":12,"title":"0x00000827","offset":2087,"out_nodes":[11]},{"id":13,"title":"sym.imp.__cxa_finalize","offset":1680,"out_nodes":[]},{"id":14,"title":"0x0000077e","offset":1918,"out_nodes":[13]}]}
{"nodes":[{"id":0,"title":"sym.imp.free","offset":1584,"out_nodes":[]},{"id":1,"title":"0x0000083f","offset":2111,"out_nodes":[0]},{"id":2,"title":"sym.imp.strcpy","offset":1600,"out_nodes":[]},{"id":3,"title":"0x00000814","offset":2068,"out_nodes":[2]},{"id":4,"title":"sym.imp.puts","offset":1616,"out_nodes":[]},{"id":5,"title":"0x00000833","offset":2099,"out_nodes":[4]},{"id":6,"title":"sym.imp.strlen","offset":1632,"out_nodes":[]},{"id":7,"title":"0x000007de","offset":2014,"out_nodes":[6]},{"id":8,"title":"0x000007cf","offset":1999,"out_nodes":[6]},{"id":9,"title":"sym.imp.malloc","offset":1648,"out_nodes":[]},{"id":10,"title":"0x000007f6","offset":2038,"out_nodes":[9]},{"id":11,"title":"sym.imp.strcat","offset":1664,"out_nodes":[]},{"id":12,"title":"0x00000827","offset":2087,"out_nodes":[11]},{"id":13,"title":"sym.imp.__cxa_finalize","offset":1680,"out_nodes":[]},{"id":14,"title":"0x0000077e","offset":1918,"out_nodes":[13]}]}
agraph.color_box=G1swbQ==
agraph.delta_x=0x4d
agraph.delta_y=0x1
agraph.h=0x10
agraph.is_callgraph=false
agraph.nodes=sym.imp.free,0x0000083f,sym.imp.strcpy,0x00000814,sym.imp.puts,0x00000833,sym.imp.strlen,0x000007cf,0x000007de,sym.imp.malloc,0x000007f6,sym.imp.strcat,0x00000827,sym.imp.__cxa_finalize,0x0000077e
agraph.nodes=sym.imp.free,0x0000083f,sym.imp.strcpy,0x00000814,sym.imp.puts,0x00000833,sym.imp.strlen,0x000007de,0x000007cf,sym.imp.malloc,0x000007f6,sym.imp.strcat,0x00000827,sym.imp.__cxa_finalize,0x0000077e
agraph.nodes.0x0000077e.body=base64:
agraph.nodes.0x0000077e.h=0x3
agraph.nodes.0x0000077e.neighbours=sym.imp.__cxa_finalize
Expand All @@ -222,13 +222,13 @@ agraph.nodes.0x000007cf.body=base64:
agraph.nodes.0x000007cf.h=0x3
agraph.nodes.0x000007cf.neighbours=sym.imp.strlen
agraph.nodes.0x000007cf.w=0x16
agraph.nodes.0x000007cf.x=0x4e
agraph.nodes.0x000007cf.x=0x68
agraph.nodes.0x000007cf.y=0x4d
agraph.nodes.0x000007de.body=base64:
agraph.nodes.0x000007de.h=0x3
agraph.nodes.0x000007de.neighbours=sym.imp.strlen
agraph.nodes.0x000007de.w=0x16
agraph.nodes.0x000007de.x=0x68
agraph.nodes.0x000007de.x=0x4e
agraph.nodes.0x000007de.y=0x4d
agraph.nodes.0x000007f6.body=base64:
agraph.nodes.0x000007f6.h=0x3
Expand Down
Loading