Remove the deprecated double-quote raw call ##shell - #26316
Merged
Conversation
* Things like `""x` wont work anymore, use `'x` instead
There was a problem hiding this comment.
Pull request overview
This PR removes support for the deprecated "" “raw call” command prefix in radare2’s core command parser, and updates shell command tests to reflect the new behavior (leading "" is no longer treated as a special raw-call operator).
Changes:
- Remove the deprecated
""raw-call handling and related help entries. - Introduce normalization that strips leading empty double-quotes so such inputs go through the normal parser.
- Update
test/db/cmd/shellto validate the new parsing behavior and nested substitution cases.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
libr/core/cmd.c |
Drops deprecated "" raw-call parsing, adds leading-"" stripping, and updates help text accordingly. |
test/db/cmd/shell |
Replaces "" raw-call expectations with tests asserting normal parsing after leading empty double-quotes. |
Comment on lines
+3947
to
+3948
| int res = 1; | ||
| char *arg = strdup (cmd); |
Comment on lines
+3968
to
3971
| static void remove_leading_empty_quotes(char *cmd) { | ||
| while (r_str_startswith (cmd, "\"\"")) { | ||
| memmove (cmd, cmd + 2, strlen (cmd + 2) + 1); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
""xwont work anymore, use'xinsteadDescription