write nso huge section test - #26470
Open
AGhebrea wants to merge 2 commits into
Open
Conversation
4 tasks
Contributor
Author
|
The PR in the testbins repo is radareorg/radare2-testbins#132 |
Contributor
Author
|
It seems like the tests are failing because the test binary is not yet merged into the testbins repo |
Collaborator
|
The test must be in formats/nso. This is not analyzing anything and certainly i dont see the value of adding 8mb on each ci run just for this small test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The test we talked about in #26459
I'll be creating a companion PR in radare2-testbins.
If you were meaning a unit test i can write one of those and discard this one