Skip to content

Give valgrind-wrapped leak tests a minimum timeout ##r2r #26471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trufae merged 1 commit into from
Aug 15, 2026
+5 −1
Merged

Give valgrind-wrapped leak tests a minimum timeout ##r2r #26471

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion binr/r2r/run.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@
#define R2R_ASAN 0
#endif

// valgrind makes a leak test 20-50x slower, so a native budget starves it
#define R2R_LEAK_MIN_TIMEOUT_MS (120 * 1000)

#if R2__WINDOWS__
#include <windows.h>
#else
Expand Down Expand Up @@ -1759,7 +1762,8 @@ R_API R2RProcessOutput *r2r_run_leak_test(R2RRunConfig *config, R2RCmdTest *test
extra_env = r_str_split_duplist (test->env.value, ";", true);
}

const ut64 timeout_ms = test->timeout.set? test->timeout.value * 1000: config->timeout_ms;
const ut64 want = test->timeout.set? test->timeout.value * 1000: config->timeout_ms;
const ut64 timeout_ms = R_MAX (want, R2R_LEAK_MIN_TIMEOUT_MS);

// Run with valgrind wrapping
R2RProcessOutput *out = run_r2_test_with_valgrind (config, timeout_ms, 1, test->cmds.value, files, extra_args, extra_env, test->load_plugins, runner, user);
Expand Down
Loading