Skip to content

Free all flag metadata strings ##analysis #26472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trufae merged 1 commit into from
Aug 15, 2026
Merged

Free all flag metadata strings ##analysis #26472

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion libr/flag/flag.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,10 +268,11 @@ static HtPP *flag_ht_name_new(void) {

static void ht_free_meta(HtUPKv *kv) {
if (kv) {
// free (kv->key);
RFlagItemMeta *fim = (RFlagItemMeta *)kv->value;
free (fim->type);
free (fim->comment);
free (fim->color);
free (fim->alias);
free (fim);
}
}
Expand Down
16 changes: 16 additions & 0 deletions test/unit/test_flags.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,11 +151,27 @@ bool test_r_flag_rename_unset_all(void) {
mu_end;
}

bool test_r_flag_metadata_lifetime(void) {
RFlag *flags = r_flag_new ();
mu_assert_notnull (flags, "r_flag_new () failed");

RFlagItem *fi = r_flag_set (flags, "with_metadata", 1024, 4);
mu_assert_notnull (fi, "cannot set flag");
mu_assert_streq (r_flag_item_set_type (flags, fi, "function"),
"function", "flag type set");
mu_assert_streq (r_flag_item_set_alias (flags, fi, "entry0 + 4"),
"entry0 + 4", "flag alias set");

r_flag_free (flags);
mu_end;
}

int all_tests(void) {
mu_run_test (test_r_flag_get_set);
mu_run_test (test_r_flag_by_spaces);
mu_run_test (test_r_flag_get_at);
mu_run_test (test_r_flag_rename_unset_all);
mu_run_test (test_r_flag_metadata_lifetime);
return tests_passed != tests_run;
}

Expand Down
Loading