Fix Mach-O dSYM loading through symlinks ##debug - #26474
Open
0verflowme wants to merge 1 commit into
Open
Conversation
0verflowme
marked this pull request as ready for review
August 16, 2026 02:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Companion discovery derived both the bundle path and DWARF basename from the literal input path. A symlink with a different basename therefore searched for a nonexistent companion and lost the address-owned DWARF function interface. The old path also opened the candidate through a command string and merged it without checking UUID identity.
Validation
make -jand install into a fresh private prefixtest/db/cmd/dwarf: 21/21 passingsys/lint.sh libr/core/cfile.cint sym._check_secret (int x);The regressions cover alias-owned and canonical-target companions, UUID rejection, thin and universal Mach-O candidates, misleading outer slice metadata,
io.autofd=false, and temporary binfile/IO/RFS cleanup.Existing limitation
This does not change the existing deferred-loading behavior for companion dSYMs whose
__debug_lineexceeds the 16 MiB automatic-load limit. The prioro <dSYM>; obm-path also discarded that deferred source. Fixing it requires a separate persistent external-DWARF association and explicitidx/idreplay contract.