Fix heap out of bounds read in the ppc64 plt stub segment scan ##bin - #26476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to cb8192b, which added the segment fallback to the ppc64 ELFv1 stub scan. That loop bounds on the raw
ehdr.e_phnum, buteo->phdris allocated byinit_phdrwitheo->phnum— the countElf_(get_phnum)resolves, which undere_phnum == PN_XNUM (0xffff)comes from section 0's sh_info`. A file claiming PN_XNUM while resolving to a small count reads ~65527 entries past the allocation, on open:The same mismatch truncates the scan on a legitimate file with more than 65535 program headers. Fixed by iterating
eo->phnum, as every other phdr loop in the ELF code already does.