Skip to content

fix(objectify)!: wrap return type with Partial #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: next
Choose a base branch
from
Open

fix(objectify)!: wrap return type with Partial #385

wants to merge 1 commit into from

Conversation

Yukiniro
Copy link
Contributor

@Yukiniro Yukiniro commented Mar 26, 2025 •
edited by radashi-bot
Loading

Summary

objectify will return {} when the array is []. So, Partial<Record<Key, Value>> is more suitable

Related issue, if any:

For any code change,

  • Related documentation has been updated, if needed
  • Related tests have been added or updated, if needed
  • Related benchmarks have been added or updated, if needed
  • Release notes in next-minor.md or next-major.md have been added, if needed

Does this PR introduce a breaking change?

Yes

@Yukiniro Yukiniro requested a review from aleclarson as a code owner March 26, 2025 03:06
@Yukiniro Yukiniro changed the title fix (objectify): improve type safety fix(objectify): improve type safety Mar 26, 2025
@aleclarson aleclarson changed the title fix(objectify): improve type safety fix(objectify)!: wrap return type with Partial Mar 26, 2025
@aleclarson aleclarson added BREAKING CHANGE Not backwards compatible better types This PR mainly improves type definitions labels Mar 26, 2025
@aleclarson aleclarson changed the base branch from main to next March 26, 2025 14:02
@Yukiniro @aleclarson
fix (objectify): Change return type from Record<Key, Value> to Partia…
34b7a22 
…l<Record<Key, Value>> and update tests to handle possible undefined values.
@aleclarson aleclarson added this to the v13.0.0 milestone Apr 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleclarson aleclarson Awaiting requested review from aleclarson aleclarson is a code owner

Assignees
No one assigned
Labels
better types This PR mainly improves type definitions BREAKING CHANGE Not backwards compatible
Projects
None yet
Milestone
v13.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Yukiniro @aleclarson