feat(mergeOptions): create mergeOptions function and its type
#442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fResult
force-pushed
the
fResult/mergeOptions
branch
2 times, most recently
from
0e67716 to
cd22c2f
Compare
fResult
force-pushed
the
fResult/mergeOptions
branch
from
cd22c2f to
5841401
Compare
fResult
force-pushed
the
fResult/mergeOptions
branch
from
accf1ea to
4e563c4
Compare
Benchmark Results
Performance regressions of 30% or more should be investigated, unless they were anticipated. Smaller regressions may be due to normal variability, as we don't use dedicated CI infrastructure. |
aleclarson
reviewed
Oct 17, 2025
Comment on lines
+109
to
+120
| class Character { | ||
| constructor( | ||
| public name: string, | ||
| public age: number, | ||
| ) {} | ||
| } | ||
|
|
||
| const anderson = new Character('Thomas A. Anderson', 30) | ||
| const neo = { name: 'Neo', alias: 'The One' } | ||
|
|
||
| _.mergeOptions(anderson, neo) | ||
| // => { name: 'Neo', age: 30, alias: 'The One' } |
Member
There was a problem hiding this comment.
Hmm, interesting. Is there a real world use case for this?
If not, we shouldn't document it.
aleclarson
reviewed
Oct 17, 2025
aleclarson
reviewed
Oct 17, 2025
| ? Expand<NonNullable<A>> | ||
| : Expand<MergeObjects<UndefinedToPartial<NonNullable<A>>, NonNullable<B>>> | ||
|
|
||
| type Expand<T> = T extends object ? { [K in keyof T]: Expand<T[K]> } : T |
Member
There was a problem hiding this comment.
This shouldn't be recursive, since mergeOptions isn't.
aleclarson
reviewed
Oct 17, 2025
| ? Expand<NonNullable<B>> | ||
| : [B] extends [undefined] | ||
| ? Expand<NonNullable<A>> | ||
| : Expand<MergeObjects<UndefinedToPartial<NonNullable<A>>, NonNullable<B>>> |
Member
There was a problem hiding this comment.
Shouldn't be using NonNullable on A, since that breaks UndefinedToPartial.
aleclarson
reviewed
Oct 17, 2025
aleclarson
reviewed
Oct 17, 2025
src/object/mergeOptions.ts
Outdated
Comment on lines
80
to
86
| type MergeObjects<A extends object, B extends object> = { | ||
| [K in keyof A | keyof B]: K extends keyof B | ||
| ? B[K] | ||
| : K extends keyof A | ||
| ? A[K] | ||
| : never | ||
| } |
Member
There was a problem hiding this comment.
Unfortunately, this is too simple. If B[K] is an optional property, then A[K]'s type is still possible.
aleclarson
requested changes
Oct 17, 2025
Member
aleclarson
left a comment
aleclarson
left a comment
There was a problem hiding this comment.
Thanks for the PR, @fResult! 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related issue, if any:
#414
For any code change,
Does this PR introduce a breaking change?
No
Bundle impact
src/array/objectify.tssrc/array/sort.tssrc/object/mergeOptions.tsFootnotes
Function size includes the
importdependencies of the function. ↩