Current Tint display change to "last known good state"

[tylerlv3]

Summary

Phase out JSON logging and panel state. Convert cleanly to SQLite implementation. Uses a context manager for cleaner DB operations. Remove audit.db from tracking. Move groups from panel_config.json to a table in the DB. Restructured so all remaining JSON files (config and window mapping) are read-only and all write operations occur in the DB. This completely separates run time from config files.

Type

• Feature
• Fix
• Docs
• Chore

Testing

Behaves no differently, as it is just a data storage type migration.

Risk and rollout

Medium Risk,k as we have converted to a new data storage system. Will monitor to ensure data reliability.

Checklist

• Issue linked if applicable
• Added or updated docs
• CI green
• At least one reviewer not the author

[Copilot]

Pull request overview

This PR migrates panel state tracking from JSON-only storage to a dual SQLite/JSON system as part of addressing unreliable live tint endpoint data. The migration maintains backward compatibility by continuing to write to both storage systems during the transition period, establishing a "last known good state" pattern based on successful tinting API responses.

Key changes:

• Introduces SQLite database table panel_state for tracking panel level and timestamp
• Updates state persistence to write to both SQLite and JSON for backward compatibility
• Adds update_panel_state() function called after successful tint operations to maintain accurate state

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.

File	Description
svc/data/audit.db	Binary SQLite database file (should not be committed - see comment)
svc/app/state.py	Migrates panel state storage to SQLite while maintaining JSON compatibility; adds new functions for DB initialization, migration, and single-panel updates
svc/app/service.py	Integrates update_panel_state() calls after successful panel and group tint operations to persist state based on API response success

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[imckee-dev]

how can we confirm these updates are set in the audit.db?

[tylerlv3]

If it fails at any point while trying to execute the insert, the commit after the for loop will fail, causing a rollback. So if there is no failure, it is highly assured that the operation succeeded, especially for what we have here which should always be predictable, sterile data. However, I do agree we should probably consider using an ORM instead of raw SQL, as it is easier to use and handles things such as this.

[tylerlv3]

I do now see an issue with the migration logic though, so that will have to be fixed before merge

[Copilot]

Pull request overview

Copilot reviewed 8 out of 9 changed files in this pull request and generated 10 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 12 out of 18 changed files in this pull request and generated 7 comments.

Comments suppressed due to low confidence (1)

svc/data/panels_config.json:22

• The config file references groups "G-1" and "G-2" (lines 6, 11, 16, 21) which don't appear to be defined anywhere and are inconsistent with the default groups created in bootstrap_default_if_empty() ("G-facade" and "G-skylights"). This could lead to panels not being associated with valid groups, causing issues when trying to control them via group commands.

    "P01": {
      "id": "P01",
      "name": "Facade 1",
      "group_id": "G-1"
    },
    "P02": {
      "id": "P02",
      "name": "Facade 2",
      "group_id": "G-1"
    },
    "P03": {
      "id": "P03",
      "name": "Facade 3",
      "group_id": "G-2"
    },
    "P04": {
      "id": "P04",
      "name": "Facade 4",
      "group_id": "G-2"
    },

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 13 out of 19 changed files in this pull request and generated 7 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 14 out of 20 changed files in this pull request and generated 3 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The migration functions use manual transaction handling but don't wrap the file I/O operations within the transaction. If the JSON file read fails after the count check succeeds, the database connection may be left in an inconsistent state. Consider moving the JSON file read before opening the database connection, or handle file I/O errors before starting the transaction.