Skip to content

Integration in dial - #23

Merged
tylerlv3 merged 4 commits into
mainfrom
integration-in-dial
Mar 23, 2026
Merged

Integration in dial#23
tylerlv3 merged 4 commits into
mainfrom
integration-in-dial

Conversation

@adulbrich

@adulbrich adulbrich commented Mar 18, 2026

Copy link
Copy Markdown
Contributor

Summary

This PR:

  • Ads a Dockerfile + instructions on how to build a Podman image and run it in DIAL
  • Changes the behavior of tinting. Now, instead of tinting windows (which API endpoint does not work):
    1. we first check that each window as a unique group with that single window in it
    2. if not, we create that group, using the same name as the window
    3. we use that group for tinting the window from the UI (instead of the windows endpoint, we use the groups endpoint)
  • Changed the layout of the UI to accomodate for the change: now all the windows with their group appear in a flat list in the UI, there is no more Room 1 / 2 separation.
  • Adds a /facilities/DIAL/configuration.md where each named window was mapped to its physical location (this is specific to DIAL at OSU)
  • Fixes a few bugs.

We're not using window_mapping.json anymore, bu retrieving all windows directly and creating groups based on their individual names.

Type

  • Feature
  • Fix
  • Docs
  • Chore

Testing

Manual testing + running automated tests with "real" version. "simu" not tested manually.
This has been specifically tested by building the podman image, running it on the local computer in DIAL, and making sure the windows tint individually, and that groups can also be tinted. Only tested groups of up to 3 windows for now. I realize I did not test group editing.

Risk and rollout

This changes the UI behavior a little bit and I haven't tested the "simu" mode manually.

In the future, we should introduce an interactive interface where the user can group the individual windows and skylights into real "frames"/rooms, so that their placement in the UI matches the placement in the physical world.

Checklist

  • Added or updated docs
  • CI green
  • At least one reviewer not the author

@tylerlv3

Copy link
Copy Markdown
Collaborator

Looks good, tested locally as well the best I could.

@tylerlv3
tylerlv3 merged commit 0d05cca into main Mar 23, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants