Integration in dial - #23
Merged
Merged
Conversation
Collaborator
|
Looks good, tested locally as well the best I could. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR:
/facilities/DIAL/configuration.mdwhere each named window was mapped to its physical location (this is specific to DIAL at OSU)We're not using
window_mapping.jsonanymore, bu retrieving all windows directly and creating groups based on their individual names.Type
Testing
Manual testing + running automated tests with "real" version. "simu" not tested manually.
This has been specifically tested by building the podman image, running it on the local computer in DIAL, and making sure the windows tint individually, and that groups can also be tinted. Only tested groups of up to 3 windows for now. I realize I did not test group editing.
Risk and rollout
This changes the UI behavior a little bit and I haven't tested the "simu" mode manually.
In the future, we should introduce an interactive interface where the user can group the individual windows and skylights into real "frames"/rooms, so that their placement in the UI matches the placement in the physical world.
Checklist