Open
Conversation
keflavich
reviewed
Nov 29, 2016
signal_id/_moment_errs.py
Outdated
| # Remove velocity offset to match cube._pix_cen | ||
| # Requires converting to a Quantity | ||
| moment1 = u.Quantity(moment1) | ||
| moment1 = u.Quantity(moment1.copy()) |
Contributor
There was a problem hiding this comment.
making it a Quantity doesn't automatically copy the data? I guess I didn't realize that. It might be better to have copy=True as a parameter, since that's default for, e.g., np.array
Contributor
Author
There was a problem hiding this comment.
I assumed it didn't automatically, so I'll go back and check if this is needed.
Contributor
Author
There was a problem hiding this comment.
You're right, it's automatically copied.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cube- and slice-wise moment error functions and accompanying tests.
Verified against https://github.com/jfoster17/ramps/blob/master/reduce/idl_stats.py#L56, which is verified against @low-sky's IDL code (which means it's free of bugs, right? 😁 ).
Another version of this will live in TurbuStat, until this package is a bit more ready (whenever that will be).