fix(ios): sync player state on audio session interruptions - #84
Open
tobyt42 wants to merge 1 commit into
Open
Conversation
iOS pauses AVPlayer automatically on interruption (phone calls, Siri, other apps taking audio focus) without updating playWhenReady, leaving the state machine stuck on .playing and the UI showing a stale pause button. Observe AVAudioSession.interruptionNotification to sync state to paused on interruption begin, and reactivate the session and resume playback on interruption end when the system reports shouldResume.
Contributor
|
Thanks, this is indeed a gap on main and your diagnosis is right. However, the native player overhaul in #51, landing in the coming weeks, already includes interruption handling, with a couple of extra edge cases: it captures play intent at So I'll hold this PR and close it once #51 merges. Thanks again for the report and fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
iOS pauses AVPlayer automatically on interruption (phone calls, Siri, other apps taking audio focus) without updating playWhenReady, leaving the state machine stuck on .playing and the UI showing a stale pause button. Observe AVAudioSession.interruptionNotification to sync state to paused on interruption begin, and reactivate the session and resume playback on interruption end when the system reports shouldResume.