Skip to content

Get bookmarks with collections, date-times and comment threads #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

bianchi-dy
Copy link
Contributor

@bianchi-dy bianchi-dy commented Jun 20, 2021

This is a ...
New feature (non-breaking change which adds functionality)

What does this PR do?
Scrapes the following information:

Author username
Users who have bookmarked a work, with tags, collections, date, and time
Comment threads (even the nested ones!) with users, date, and time

How was the change made?
Added new functions and columns per item, i.e. get_bookmarks, get_all_comments. get_all_comments is nested as a sort of hack since it uses recursion to get to the deepest level of the comment thread.

Things I'd like feedback on
Code elegance, I suppose? Or any stuff I missed in my merge

What next?

  • Fix conflicts
  • Check if everything is working with the new merges
  • Working on a fandom analysis study with some friends from the YOI fandom! I'd like to credit this repository if we end up publishing anything, if that would be ok with you two.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant