Rebased v54 #1

wadagso-gertjaap · 2025-01-20T08:49:49Z

Rebased our changes onto upstream v54 to pull in the latest changes

* perf(eof): avoid some allocations * Update crates/primitives/src/bytecode/eof.rs

* chore: fix some typos * chore: remove useless Arc::clone

* refactor: use is_zero for U256 and B256 * fmt * Update crates/interpreter/src/instructions/arithmetic.rs Co-authored-by: DaniPopes <[email protected]> * fix deref * move import --------- Co-authored-by: DaniPopes <[email protected]>

* feat: use batch bn256 pair operation We are currently not taking advantage of the batch pair operation from the `bn` library for the pairing check precompile. This yields a ~27% speedup on the existing bench: ``` Crypto Precompile benchmarks/precompile bench | ecpairing precompile time: [2.2389 ms 2.2441 ms 2.2495 ms] change: [-27.689% -27.469% -27.227%] (p = 0.00 < 0.05) Performance has improved. ``` * use with_capacity * import vec

…nd EofError (bluealloy#1649) * feat: implement Error trait for EofValidationError * feat: implement Error trait for EofError * fix: remove unused import * fix: remove format macro

Bumps [thiserror](https://github.com/dtolnay/thiserror) from 1.0.62 to 1.0.63. - [Release notes](https://github.com/dtolnay/thiserror/releases) - [Commits](dtolnay/thiserror@1.0.62...1.0.63) --- updated-dependencies: - dependency-name: thiserror dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [tokio](https://github.com/tokio-rs/tokio) from 1.38.0 to 1.38.1. - [Release notes](https://github.com/tokio-rs/tokio/releases) - [Commits](tokio-rs/tokio@tokio-1.38.0...tokio-1.38.1) --- updated-dependencies: - dependency-name: tokio dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix(EOF): Overflow on num_sections * fix test * fmt/clippy

…uealloy#1648) * feat(EOF): EOF Validation add code type and sub container tracker * fix * omit tests * fix some things, bump test suite * fix(EOF): Overflow on num_sections * cleanup fmt * clippy * fix tests * Run EOF validation tests

* wip: test * fix(EOF): Validate code access in stack * add code access

* feat(EOF): Add non-returning CALLF/JUMPF checks * fix tests

…uealloy#1664)

Bumps [serde_json](https://github.com/serde-rs/json) from 1.0.120 to 1.0.121. - [Release notes](https://github.com/serde-rs/json/releases) - [Commits](serde-rs/json@v1.0.120...v1.0.121) --- updated-dependencies: - dependency-name: serde_json dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [tokio](https://github.com/tokio-rs/tokio) from 1.38.1 to 1.39.2. - [Release notes](https://github.com/tokio-rs/tokio/releases) - [Commits](tokio-rs/tokio@tokio-1.38.1...tokio-1.39.2) --- updated-dependencies: - dependency-name: tokio dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [blst](https://github.com/supranational/blst) from 0.3.12 to 0.3.13. - [Release notes](https://github.com/supranational/blst/releases) - [Commits](supranational/blst@v0.3.12...v0.3.13) --- updated-dependencies: - dependency-name: blst dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [serde_json](https://github.com/serde-rs/json) from 1.0.121 to 1.0.122. - [Release notes](https://github.com/serde-rs/json/releases) - [Commits](serde-rs/json@v1.0.121...v1.0.122) --- updated-dependencies: - dependency-name: serde_json dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [alloy-eips](https://github.com/alloy-rs/alloy) from 0.2.0 to 0.2.1. - [Release notes](https://github.com/alloy-rs/alloy/releases) - [Changelog](https://github.com/alloy-rs/alloy/blob/main/CHANGELOG.md) - [Commits](alloy-rs/alloy@v0.2.0...v0.2.1) --- updated-dependencies: - dependency-name: alloy-eips dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [regex](https://github.com/rust-lang/regex) from 1.10.5 to 1.10.6. - [Release notes](https://github.com/rust-lang/regex/releases) - [Changelog](https://github.com/rust-lang/regex/blob/master/CHANGELOG.md) - [Commits](rust-lang/regex@1.10.5...1.10.6) --- updated-dependencies: - dependency-name: regex dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [rstest](https://github.com/la10736/rstest) from 0.21.0 to 0.22.0. - [Release notes](https://github.com/la10736/rstest/releases) - [Changelog](https://github.com/la10736/rstest/blob/master/CHANGELOG.md) - [Commits](la10736/rstest@v0.21.0...v0.22.0) --- updated-dependencies: - dependency-name: rstest dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Osaka Activation Accept Osaka in unit tests and eof validation tests. * update test cases * remove evmone (they are all Prague based) * remove evmone exclusions * use [email protected] for eest * port in EXTDELEGATE precompile fix * fmt * Leave space for arbitrary forks in eof validation * only count validated tests * remove references to test directories that are not valid with current specs * refactor flow slightly * clippy * fmt

…loy#1845) * perf(precompile): use secp256k1 global context for ecrecover * remove secp var

* feat: to_plain_state * feat: extend to reverts Co-authored-by: James Prestwich <[email protected]>

* chore: remove Parity re-export * bump eip7702

…1864)

* perf(CacheAccount): remove unneeded clone * perf(TransitionAccount): remove unneeded clone

* feat: eip-7623 * remove double iteration on data

* chore: bump alloy-eip7702 * clippy * bump tests and fix auth chain_id check bug * remove prints * feat: apply latest EIP-7702 changes * fmt * bump alloy

* feat: eip7691 fraction update * reitroduce max blob check for tx for cancun * nit

* chore: eip7702 chainid u256 change * feat: remove g1/g2 mul, shift address * bump tests * rm test with non empty storage * no std * rm obsolete tests

* bump: alloy core and use PrimitiveSignature * bump version

* feat: handle isthmus operator fee * fix: inverse if condition

* chore: optimize tx l1 fetches * add std box

* fix(op): move l1block loading to verification * clear full l1block data

* feat(EIP-7623): adjuct floor gas check order * serde default

* feat(EIP-7623): adjuct floor gas check order * serde default * chore: bump v54 revm v19.3.0

maurermi · 2025-01-20T13:36:17Z

Looks like there are some merge conflicts to deal with here, but all good with rebasing this in

wadagso-gertjaap · 2025-01-20T16:02:38Z

Opened a new PR for this - #2

DaniPopes and others added 30 commits July 17, 2024 15:32

chore(eof): simplify magic checks (bluealloy#1633)

782c3dd

perf(eof): avoid some allocations (bluealloy#1632)

bac2f4a

* perf(eof): avoid some allocations * Update crates/primitives/src/bytecode/eof.rs

chore: fix some typos & remove useless Arc::clone (bluealloy#1621)

1a13e2a

* chore: fix some typos * chore: remove useless Arc::clone

feat(interpreter): derive traits on FunctionStack (bluealloy#1640)

1adc908

chore: Renamed some city name (bluealloy#1645)

d980839

perf: avoid cloning original_bytes (bluealloy#1646)

b995fad

fix(eof): deny static context in EOFCREATE (bluealloy#1644)

a605d05

feat(EOF): implement std::error::Error trait for EofValidationError a…

013de92

…nd EofError (bluealloy#1649) * feat: implement Error trait for EofValidationError * feat: implement Error trait for EofError * fix: remove unused import * fix: remove format macro

fix(EOF): Overflow on num_sections (bluealloy#1656)

d71acb5

* fix(EOF): Overflow on num_sections * fix test * fmt/clippy

fix(statetest): Add back Merge spec (bluealloy#1658)

28b7021

fix(EOF): Validate code access in stack (bluealloy#1659)

9eabd4b

* wip: test * fix(EOF): Validate code access in stack * add code access

feat(EOF): Add EOF validation in revme bytecode cmd (bluealloy#1660)

1163e29

chore(clippy): 1.80 rust clippy list paragraph ident (bluealloy#1661)

83df9c4

feat(EOF): Add non-returning CALLF/JUMPF checks (bluealloy#1663)

dc2b334

* feat(EOF): Add non-returning CALLF/JUMPF checks * fix tests

fix(EOF): returning to non-returning jumpf, enable valition error (bl…

42bbc74

…uealloy#1664)

fix: add DATACOPY to OpCode::modifies_memory (bluealloy#1639)

371e8c2

chore(eof): Add opcodes that expand memory (bluealloy#1665)

7a35122

fix(statetest): make bytecode analyzed (bluealloy#1666)

49d68c8

shemnon and others added 26 commits October 28, 2024 10:41

perf(precompile): use secp256k1 global context for ecrecover (blueal…

9dcd87c

…loy#1845) * perf(precompile): use secp256k1 global context for ecrecover * remove secp var

feat: to_plain_state (bluealloy#1778) (bluealloy#1841)

7d24989

* feat: to_plain_state * feat: extend to reverts Co-authored-by: James Prestwich <[email protected]>

chore: bump alloy-eip7702 and remove Parity re-export (bluealloy#1842)

4360ea1

* chore: remove Parity re-export * bump eip7702

bump: tag v50, revm v18.0.0, changelogs (bluealloy#1849)

900409f

perf: Add static Optimism precompiles for Fjord & Granite (bluealloy#…

9519b11

…1864)

[v50] perf: remove unneeded clones (bluealloy#1863)

4f76291

* perf(CacheAccount): remove unneeded clone * perf(TransitionAccount): remove unneeded clone

chore: refactor L1BlockInfo::tx_estimated_size_fjord (bluealloy#1862)

a002459

feat(Prague): EIP-7623 Increase Calldata Cost (bluealloy#1744)

6882e22

* feat: eip-7623 * remove double iteration on data

EIP-7742: Uncouple blob count between CL and EL (bluealloy#1899)

4e00f32

feat: apply latest EIP-7702 changes (bluealloy#1850)

d8ca097

* chore: bump alloy-eip7702 * clippy * bump tests and fix auth chain_id check bug * remove prints * feat: apply latest EIP-7702 changes * fmt * bump alloy

feat: eip7691 fraction update (bluealloy#1900)

12b0bab

* feat: eip7691 fraction update * reitroduce max blob check for tx for cancun * nit

feat: add Isthmus spec (bluealloy#1948)

e30fe19

chore: eip7702 chainid u256 change (bluealloy#1950)

0c69ccd

feat: blst reprice, remove g1/g2 mul, eest test bump (bluealloy#1951)

66ee506

* chore: eip7702 chainid u256 change * feat: remove g1/g2 mul, shift address * bump tests * rm test with non empty storage * no std * rm obsolete tests

chore: bump for v51, revm v19.0.0 versions (bluealloy#1953)

8507c1c

bump: alloy core and use PrimitiveSignature (bluealloy#1954)

d6b90a0

* bump: alloy core and use PrimitiveSignature * bump version

fix: add proper part to devnet5 tests

811bc7d

feat: handle isthmus operator fee (bluealloy#1960)

226f059

* feat: handle isthmus operator fee * fix: inverse if condition

chore: optimize tx l1 fetches (bluealloy#1967)

9dd9f9e

* chore: optimize tx l1 fetches * add std box

bump: revm 19.1.0, tag v52 (bluealloy#1968)

ae26414

fix(op): move l1block loading to verification (bluealloy#1970)

1054af9

* fix(op): move l1block loading to verification * clear full l1block data

bump: v53 revm v19.2.0 (bluealloy#1972)

b59f255

chore: rm deprecated bls test (bluealloy#1982)

10d3e1d

feat(EIP-7623): adjuct floor gas check order (bluealloy#1990)

246f483

* feat(EIP-7623): adjuct floor gas check order * serde default

chore: Bump v54 (bluealloy#1992)

b88b720

* feat(EIP-7623): adjuct floor gas check order * serde default * chore: bump v54 revm v19.3.0

wadagso-gertjaap force-pushed the rebased-v54 branch from 06c1def to b88b720 Compare January 20, 2025 13:26

wadagso-gertjaap closed this Jan 20, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rebased v54 #1

Rebased v54 #1

Uh oh!

wadagso-gertjaap commented Jan 20, 2025

Uh oh!

maurermi commented Jan 20, 2025

Uh oh!

wadagso-gertjaap commented Jan 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Rebased v54 #1

Rebased v54 #1

Uh oh!

Conversation

wadagso-gertjaap commented Jan 20, 2025

Uh oh!

maurermi commented Jan 20, 2025

Uh oh!

wadagso-gertjaap commented Jan 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants