Popper: Fix anchor positioning when using custom anchor#3807
Open
Benrski wants to merge 3 commits intoradix-ui:mainfrom
Open
Popper: Fix anchor positioning when using custom anchor#3807Benrski wants to merge 3 commits intoradix-ui:mainfrom
Benrski wants to merge 3 commits intoradix-ui:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 976f2fb The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When both
PopoverAnchorandPopoverTriggerare present, the trigger briefly registers itself as the anchor. After the custom anchor takes over, its effect compares against its own previous value, sees no change, and skips the update — so the popover stays on the trigger.This PR compares against the current anchor in context instead of a local previous value. This should still prevent unnecessary updates while correctly picking up the custom anchor.
Closes #3659
Closes #3760