fix(otp): stale dispatch in React 19.2#3831
Open
askides wants to merge 3 commits intoradix-ui:mainfrom
Open
Conversation
🦋 Changeset detectedLatest commit: 2f7959c The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & Why
The OTP field stopped working in React 19.2 because the
dispatchfunction captured stalevalueandcollectionstate viauseEffectEvent. This caused typed digits to not persist and keyboard navigation to break. This replacesuseEffectEventwithuseCallback+ a ref sodispatchalways reads the latest value while keeping a stable function identity.Changes
useEffectEventwithReact.useCallbackfor thedispatchfunction inOneTimePasswordFieldlatestValueRefsodispatchreads freshvaluewithout needing it as a dependency (keeps dispatch identity stable, avoids cascading effect re-runs)@radix-ui/react-use-effect-eventimportHow to Test
pnpm dev→ open Storybookpnpm vitest run packages/react/one-time-password-fieldCloses #3709