fix(slider): handle scientific notation in getDecimalCount for steps …#3853
Open
nilesh65 wants to merge 1 commit intoradix-ui:mainfrom
Open
fix(slider): handle scientific notation in getDecimalCount for steps …#3853nilesh65 wants to merge 1 commit intoradix-ui:mainfrom
nilesh65 wants to merge 1 commit intoradix-ui:mainfrom
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(slider): handle precision for values <= 1e-7
Fixes #3852
Description
Fixes an issue where Slider precision breaks for values <= 1e-7 due to improper handling of scientific notation in decimal count calculation.
The previous implementation of
getDecimalCountdid not correctly handle scientific notation values, leading to incorrect slider step precision calculation.This update ensures:
This is a non-breaking internal fix with no changes to public API.
Testing
pnpm test)Notes