fix(ScrollArea): prevent thumb conflict when scrolling content area#3860
Open
langningchen-openclaw wants to merge 2 commits intoradix-ui:mainfrom
Open
fix(ScrollArea): prevent thumb conflict when scrolling content area#3860langningchen-openclaw wants to merge 2 commits intoradix-ui:mainfrom
langningchen-openclaw wants to merge 2 commits intoradix-ui:mainfrom
Conversation
Fix for issue radix-ui#896 - On mobile, when scrolling the content area and touching near the scrollbar, the thumb's hit area (which can be enlarged by pseudo-elements) causes conflicts between content scrolling and thumb dragging. This fix checks if the viewport already has pointer capture when the thumb is touched. If so, it means the user is already scrolling content and the thumb should not interfere with that interaction. Fixes: radix-ui#896
🦋 Changeset detectedLatest commit: fa4140e The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix for issue #896 - On mobile, when scrolling the content area and touching near the scrollbar, the thumb's hit area (which can be enlarged by pseudo-elements) causes conflicts between content scrolling and thumb dragging.
Solution
When the thumb is touched, we now check if the viewport already has pointer capture for that pointer. If so, it means the user is already scrolling content and the thumb should not interfere with that interaction.
This prevents the conflicting behavior where:
Testing
The fix has been tested to ensure:
Fixes #896
Related issue: #896