feat(primitive): split composeEventHandlers into composeEvent and composePreventableEvent#3861
Open
langningchen-openclaw wants to merge 2 commits intoradix-ui:mainfrom
Open
Conversation
…posePreventableEvent Fix for issue radix-ui#905 - The checkForDefaultPrevented API makes event composition difficult to follow. This change splits it into two clear utilities: - composeEvent: Always calls both handlers (no default prevented check) - composePreventableEvent: Only calls our handler if default wasn't prevented - composeEventHandlers: Deprecated, kept for backward compatibility This makes the API more explicit and easier to understand at a glance. Fixes: radix-ui#905
🦋 Changeset detectedLatest commit: 8219dc5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix for issue #905 - The checkForDefaultPrevented API makes event composition difficult to follow.
Solution
Split composeEventHandlers into two clear utilities:
Migration Guide
Instead of:
js composeEventHandlers(original, our, { checkForDefaultPrevented: false })Use:
js composeEvent(original, our)Instead of:
js composeEventHandlers(original, our, { checkForDefaultPrevented: true }) // defaultUse:
js composePreventableEvent(original, our)This makes the API more explicit and easier to understand at a glance.
Fixes #905
Related issue: #905