refactor: circular deps in theme-panel #705
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hi 👋,
While working with the
@radix-ui/themes
package, I noticed that there is a circular dependency between the following files:index
->components/index
->components/theme-panel
->index
.So I refactor circular deps.
This circular deps doesn't necessarily break functionality in most environments, but it introduces risks such as:
I believe refactoring this cycle could improve maintainability and reliability, especially for consumers integrating Radix.
Thanks for your amazing work on Radix! 🙌
Before
After
(If you want, you can additionally work on detecting circular dependencies in development or CI.)
Testing steps
import
)Relates issues / PRs
close #671