[fix] fix truncate function return routed expert#1069
Open
zyzshishui wants to merge 1 commit intoradixark:mainfrom
Open
[fix] fix truncate function return routed expert#1069zyzshishui wants to merge 1 commit intoradixark:mainfrom
zyzshishui wants to merge 1 commit intoradixark:mainfrom
Conversation
…_tokens Replace the inline _truncate_sample_output helper with Sample.strip_last_output_tokens. The helper takes the count to strip from the end, so pass overshoot (= response_length - allowed_output), not allowed_output itself. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
zyzshishui
requested review from
fzyzcjy,
guapisolo and
yueming-yuan
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the sample truncation logic in openai_endpoint_utils.py by replacing the internal _truncate_sample_output function with the Sample.strip_last_output_tokens method. Feedback suggests moving the assignment of the TRUNCATED status into the strip_last_output_tokens method itself to prevent logic duplication and ensure consistency across the codebase.
zyzshishui
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the inline _truncate_sample_output helper with Sample.strip_last_output_tokens. The helper takes the count to strip from the end, so pass overshoot (= response_length - allowed_output), not allowed_output itself.
Fix #861