ull Request: Windows Support, Multi-Account Grid View, and Privacy Enhancements#611
Open
105211-ui wants to merge 14 commits intorafatosta:mainfrom
Open
ull Request: Windows Support, Multi-Account Grid View, and Privacy Enhancements#611105211-ui wants to merge 14 commits intorafatosta:mainfrom
105211-ui wants to merge 14 commits intorafatosta:mainfrom
Conversation
7d088bb to
8e2166c
Compare
Owner
|
A very significant change. I'm reviewing it very calmly and cautiously, but so far I haven't found any problems for me to reject your PR. Thank you very much for the contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request: Windows Support, Multi-Account Grid View, and Privacy Enhancements
🚀 Overview
This PR introduces significant features aimed at improving cross-platform compatibility and privacy for power users. Key additions include full Windows build support, a new Grid View for managing multiple accounts simultaneously, WebRTC IP-leak protection, and per-account proxy configurations.
✨ Detailed Changes
🏁 1. Windows Compatibility & Build System
ZapZap.specto correctly bundle translations (po), UI files, and the newwebrtc_shield.jsfor Windows builds.run.pywith a new--windowsbuild target.pyuic6on Windows.zapzap/platform/to handle cross-platform pathing and detection more reliably.🖼️ 2. Multi-Account Grid View
WebViewupon switching, ensuring the grid always shows the last-seen state of each account.🛡️ 3. Privacy: WebRTC Shield
webrtc_shield.js, a specialized shim that overrides the browser'sRTCPeerConnectionAPI to prevent the leaking of local and public IP addresses.WebView.pyto inject the shield immediately upon document creation across all subframes.🌐 4. Per-Account Proxy Support
PageNetwork.pyto include an account selector.ProxyManager.pyto store and retrieve proxy settings using a per-account prefix. This allows users to assign a different proxy (or none at all) to each WhatsApp instance individually.Browsercontroller now triggers a proxy update whenever the active account is switched, ensuring traffic is routed correctly for the visible session.🛠️ Testing Performed
python run.py build --windowsgenerates a functional executable in thedist/folder.browserleaks.com/webrtcthat real IPs are masked when the shield is enabled.