-
Notifications
You must be signed in to change notification settings - Fork 0
WIP [explicit video refs] new server #139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
osdiab
wants to merge
31
commits into
master
Choose a base branch
from
osdiab/feature/explicit-video-refs-new-server
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
0eab795
media reference object types
osdiab 4233ebd
add legacy operation types
osdiab 1d7a92d
add legacy types for api responses
osdiab f5ca808
allow endpoints that involve video tokens to either be current or leg…
osdiab ae86265
fix incorrect types in shared models
osdiab 9be742a
make client routes only pass in content of video reference
osdiab 782072f
just store operations as merged legacy and current version for impl s…
osdiab b2813d1
operationsFlaggingThisMember optional, email_address_verified boolean…
osdiab 0b71cab
add crypto-random-string dep
osdiab fa1d262
add random ID generation
osdiab 362345e
move video moving functions from createMember to helper file
osdiab 690a83a
add legacy invite video helper for copying new invite videos to publi…
osdiab e1cbdb5
add getPublicUrl helpers in legacy
osdiab 92e7346
use getPublicUrl helper in verify
osdiab 28dcf2b
more explicit return types in legacy helpers
osdiab f5fc883
store videos at new generated id, object args/returns
osdiab fc631b5
sendInvite now uses videoReference
osdiab 029ca1d
pass sendInvite params as an object
osdiab 5b4c81e
minor comments changes
osdiab c293e3a
move create video reference legacy helper to legacy helpers file
osdiab ac2d62f
add comments for legacy video helpers
osdiab f7a7925
Reorg legacy video methods
osdiab 84f3780
rename legacy video methods again and better comment what's going on …
osdiab a01d558
memberUid -> memberId
osdiab 0c13ace
Rename publicinvitevideoref to publicidentityvideoref
osdiab 2661ebe
simplify video helpers identity ref fn
osdiab c2ec111
named args for createInvitedMember/createUninvtedMember, req email ad…
osdiab 213c35d
rename legacy_ to legacy_compat_ methods for sendInvite
osdiab d70e814
rewordings of legacy fns
osdiab 32dc6a0
make legacy identity video creation method robust to any video stored…
osdiab 53a5dcd
place videos properly for legacy compatibility in createMember
osdiab File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
import cryptoRandomString = require("crypto-random-string"); | ||
|
||
/** | ||
* Generates an unpredictable identifier. Not globally unique, but pretty | ||
* unlikely to collide. | ||
*/ | ||
export function generateId(): string { | ||
return cryptoRandomString(32); | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This package appears to be all of one line, can we just use said line https://github.com/sindresorhus/crypto-random-string/blob/master/index.js#L9 and avoid yet another external dep?