Skip to content

Conversation

@MacLove13
Copy link

Redesigned the pagination component to display it in a simpler way and with the option for the user to navigate to:

  • Next page
  • Previous page
  • First page
  • Last page

Covering changes in component display behavior depending on which page the user is on, for example, close to the first or last page and when on the first or last page.

Screens:
image

image image image image image

@MacLove13
Copy link
Author

As it is a completely new component, I ended up recreating the tests on it and checking yet another new scenario, that of displaying the number of the last page.
@rosa ready for review ;)

@ibrahima
Copy link

I don't want to put pressure on anyone, and I appreciate everyone's hard work on this gem, but it would make me exceedingly happy if this were to go into a future release. It can be quite difficult to navigate to recent jobs since the failed jobs are currently sorted in ascending order, so to get to recent jobs I often end up having to edit the page number in the URL because there's no way to get to the last page easily. Perhaps the intention is that you should clear failed jobs periodically but if that's not done regularly it can get out of hand. Thank you!

@MacLove13
Copy link
Author

I don't want to put pressure on anyone, and I appreciate everyone's hard work on this gem, but it would make me exceedingly happy if this were to go into a future release. It can be quite difficult to navigate to recent jobs since the failed jobs are currently sorted in ascending order, so to get to recent jobs I often end up having to edit the page number in the URL because there's no way to get to the last page easily. Perhaps the intention is that you should clear failed jobs periodically but if that's not done regularly it can get out of hand. Thank you!

the page= param still exists in the url

Copy link

@subins2000 subins2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this PR out locally, and it is working fine!

@MacLove13
Copy link
Author

@rosa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants