Add basic theme select #262
Conversation
|
@rosa, any chances we can get this merged? |
|
Hey @markivancho, sorry for the delay. I think this would need some changes. I'll try to review soon. |
| (function() { | ||
| var theme = localStorage.getItem("mission_control_theme") || "system"; | ||
| document.documentElement.setAttribute("data-theme", theme); | ||
| })(); |
There was a problem hiding this comment.
This should follow the gem's conventions, so that no JavaScript code is included directly like this.
|
What I don't like very much is that the new button takes up a whole row above everything, it's quite visible and important, when the default ( |
Agree, I was struggling with the placement and decided to move forward with the simplest solution. If you have some better ideas, I will happily adjust the code |
2 participants
Hey!
Something I would really benefit from, hopefully I'm not the only one who uses dark mode in the system but wants certain apps to be in light.
theme.select.mov