-
Notifications
You must be signed in to change notification settings - Fork 119
Improve HTML semantics and accessibility #299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR improves HTML semantics and accessibility across the Mission Control Jobs interface by adding proper landmark elements, fixing table structure, enhancing ARIA attributes for navigation, replacing invalid disabled link attributes, and modernizing HTML5 syntax.
Key changes:
- Added
<header>and<main>landmark elements to the application layout for better document structure - Fixed table markup by ensuring
<thead>appears before<tbody>across all tables - Replaced invalid
disabledattributes on links with proper<span>elements usingis-disabledclass andaria-disabled="true"
Reviewed changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| app/views/mission_control/jobs/workers/index.html.erb | Removed trailing whitespace and blank line |
| app/views/mission_control/jobs/workers/_workers_page.html.erb | Fixed table structure with thead before tbody |
| app/views/mission_control/jobs/workers/_worker.html.erb | Changed <br /> to <br> for HTML5 compliance |
| app/views/mission_control/jobs/workers/_raw_data.html.erb | Changed <hr /> to <hr> for HTML5 compliance |
| app/views/mission_control/jobs/workers/_configuration.html.erb | Changed <hr /> to <hr> for HTML5 compliance |
| app/views/mission_control/jobs/shared/_pagination_toolbar.html.erb | Replaced invalid disabled link attributes with proper span elements and aria-disabled |
| app/views/mission_control/jobs/shared/_jobs.html.erb | Fixed table structure with thead before tbody |
| app/views/mission_control/jobs/recurring_tasks/index.html.erb | Fixed table structure with thead before tbody |
| app/views/mission_control/jobs/recurring_tasks/_title.html.erb | Added role attributes to heading structure (problematic implementation) |
| app/views/mission_control/jobs/recurring_tasks/_general_information.html.erb | Added scope="row" to table headers for better accessibility |
| app/views/mission_control/jobs/queues/show.html.erb | Fixed table structure with thead before tbody |
| app/views/mission_control/jobs/queues/index.html.erb | Fixed table structure with thead before tbody |
| app/views/mission_control/jobs/queues/_queue_title.html.erb | Added role attributes to heading structure (problematic implementation) |
| app/views/mission_control/jobs/jobs/index.html.erb | Removed trailing blank line |
| app/views/mission_control/jobs/jobs/failed/_backtrace_toggle.html.erb | Added aria-current to active navigation links |
| app/views/mission_control/jobs/jobs/_title.html.erb | Added role attributes to heading structure (problematic implementation) |
| app/views/mission_control/jobs/jobs/_general_information.html.erb | Added scope="row" to table headers for better accessibility |
| app/views/mission_control/jobs/jobs/_error_information.html.erb | Added scope="row" to table headers for better accessibility |
| app/views/layouts/mission_control/jobs/application_selection/_servers.html.erb | Added aria-current to active server selection links |
| app/views/layouts/mission_control/jobs/application_selection/_applications.html.erb | Changed static anchor to navigable link (may break dropdown behavior) |
| app/views/layouts/mission_control/jobs/application.html.erb | Added header and main landmarks, changed section to div |
| app/views/layouts/mission_control/jobs/_navigation.html.erb | Added aria-current to active navigation links |
| app/views/layouts/mission_control/jobs/_flash.html.erb | Added role="alert" to flash message body |
| app/views/layouts/mission_control/jobs/_application_selection.html.erb | Removed role and aria-label from navbar |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
<header>and<main>landmarks to layout<thead>before<tbody>)scope="row"to definition table headersaria-current="page"to active navigation linksdisabledattribute on links with proper<span>elementsrole="alert"to flash messages<br>,<hr>)