Adjust data: URI mediatype tests for loofah 2.25.2 - #222
Merged
Conversation
flavorjones
changed the title
data: URI mediatype tests for loofah 2.25.2
Loofah v2.25.2 will parse `data:` URI mediatypes following the WHATWG `data:` URL spec, so an omitted or invalid mediatype will resolve to `text/plain` and thus will be allowed, matching how a browser reads it. This gem supports `loofah ~> 2.25`, so the tests branch on `Loofah::VERSION` and pass against both old and new loofah. ref: flavorjones/loofah#305 ref: https://fetch.spec.whatwg.org/#data-urls
flavorjones
force-pushed
the
fix-mediatype-tests
branch
from
July 14, 2026 15:54
3a5174b to
acd298b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Loofah v2.25.2 will parse
data:URI mediatypes following the WHATWGdata:URL spec, so an omitted or invalid mediatype will resolve totext/plainand thus will be allowed, matching how a browser reads it.This gem supports
loofah ~> 2.25, so the tests branch onLoofah::VERSIONand pass against both old and new loofah.ref: flavorjones/loofah#305
ref: https://fetch.spec.whatwg.org/#data-urls