Obfuscate assignment to module.exports to prevent warnings #338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Please add a test for generated JS doesn't contain Example: https://github.com/railsware/js-routes/blob/main/spec/js_routes/options_spec.rb#L519 |
Some javascript bundles (like vite) emit warnings when they encounter module.export in an ESM module. This just hides that assignment a little so that that warning doesn't appear. The spec is a little odd, as I wanted to avoid rewriting the comment in the routes file to avoid saying module.exports, so it strips out single-line javascript comments.
bagedevimo
force-pushed
the
obfuscate-module-exports
branch
from
32ffffe to
f41e0be
Compare
bogdan
approved these changes
Dec 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some javascript bundles (like vite) emit warnings when they encounter
module.export in an ESM module. This just hides that assignment a little
so that that warning doesn't appear.
Fixes #337