Skip to content

Fix/fix react router v7 application building #1303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
coffee-cup merged 9 commits into from
Apr 25, 2025
Merged

Fix/fix react router v7 application building #1303

coffee-cup merged 9 commits into from
Apr 25, 2025

Conversation

@fattila16
Copy link
Contributor

@fattila16 fattila16 commented Apr 10, 2025

This PR is fixing the issue described in: #1302

@fattila16 fattila16 mentioned this pull request Apr 10, 2025
Closed
1 task
@fattila16 fattila16 force-pushed the fix/fix-react-router-v7-application-building branch from cd98537 to b478a27 Compare April 10, 2025 14:19
coffee-cup
coffee-cup approved these changes Apr 11, 2025
View reviewed changes
Copy link
Contributor

@coffee-cup coffee-cup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@fattila16
Copy link
Contributor Author

fattila16 commented Apr 11, 2025

A clippy error was fixed in this PR too. A more important issue is that the rust-ring example was failing. I don't have that much rust knowledge, I check out the rust provider and saw that in case of musl is needed two nix pkgs are installed. Namely: musl and musl.dev. The later, musl.dev I can't seem to find it on the nixos package registry (Maybe I wasn't searching in the correct place?). Therefor I've added the musl-tools apt package. This seems to fix this issue.

@fattila16 fattila16 force-pushed the fix/fix-react-router-v7-application-building branch from bae978e to 4879279 Compare April 15, 2025 08:11
@coffee-cup coffee-cup added the release/patch Author patch release label Apr 24, 2025
@coffee-cup coffee-cup merged commit 82288ee into railwayapp:main Apr 25, 2025
104 checks passed
@enie123 enie123 mentioned this pull request May 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coffee-cup coffee-cup coffee-cup approved these changes

Assignees

No one assigned

Labels

release/patch Author patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fattila16 @coffee-cup