-
Notifications
You must be signed in to change notification settings - Fork 315
refactor(providers): specify NIXPACKS_PYTHON_PACKAGE_MANAGER
#1304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
NIXPACKS_PYTHON_PACKAGE_MANAGER
|
Currently, when both requirements.txt and uv.lock exist in a project, the system automatically prioritizes pip (via requirements.txt) because of the fixed priority order in the code. I need to keep requirements.txt in my project for general pip compatibility, but specifically on Railway I'd like to try using uv instead. This PR would allow overriding the default package manager selection through the NIXPACKS_PYTHON_PACKAGE_MANAGER configuration variable, making it possible to choose uv even when requirements.txt is present. |
coffee-cup
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! ty
|
yw, will take a look at the clippy lint failure my bad sorry! |
|
Reviewable once more 🫡 |
|
Just a few more linting failures. You should be able to fix these automatically (or see where they are) with |
a1c6264 to
82936aa
Compare
|
I just see one, think I got it! |
|
This pull request is stale because it has been open 10 days with no activity. Remove stale label or comment or this will be closed in 5 days |
…ected PackageManager enum
82936aa to
4c00fc1
Compare
Ready to review, not stale! @coffee-cup |
This PR refactors the Python rewrite package manager choice logic using an enum to make the decision tree explicitly clear, and thus also to allow a particular branch to be specified in config
Poetry.lock>uv.lockTasks
NIXPACKS_PYTHON_PACKAGE_MANAGERas "poetry", "uv", etc.