Add tests in meta file

[findolor]

Motivation

See issue: #1628

Solution

Checks

By submitting this for review, I'm confirming I've done the following:

• made this PR as small as possible
• unit-tested any new functionality
• linked any relevant issues or PRs
• included screenshots (if this involves a front-end change)

fix #1628

Summary by CodeRabbit

• Tests
  • Added unit tests to verify correct decoding and error handling for Rainlang source metadata.

[coderabbitai]

Walkthrough

A new test module has been introduced in the crates/common/src/meta.rs file. This module contains unit tests for the try_decode_rainlangsource method of the SgRainMetaV1 struct. The tests cover scenarios such as successful decoding, missing magic prefix, invalid hex input, and corrupt metadata, ensuring the method's error handling and decoding logic are correctly implemented. No changes were made to the signatures or declarations of any exported or public entities.

Changes

File(s)	Change Summary
crates/common/src/meta.rs	Added a private test module under #[cfg(test)] with unit tests for try_decode_rainlangsource method

Assessment against linked issues

Objective	Addressed	Explanation
Add missing tests for meta.rs in the common crate (#1628)	✅

Suggested reviewers

• hardyjosh

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9c4c519 and 5ef5490.

📒 Files selected for processing (1)

• crates/common/src/meta.rs (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (16)

• GitHub Check: standard-tests (ubuntu-latest, rainix-wasm-artifacts)
• GitHub Check: standard-tests (ubuntu-latest, rainix-sol-legal)
• GitHub Check: standard-tests (ubuntu-latest, test-js-bindings)
• GitHub Check: standard-tests (ubuntu-latest, rainix-sol-test)
• GitHub Check: standard-tests (ubuntu-latest, rainix-sol-static)
• GitHub Check: standard-tests (ubuntu-latest, rainix-wasm-test)
• GitHub Check: standard-tests (ubuntu-latest, rainix-rs-static)
• GitHub Check: standard-tests (ubuntu-latest, ob-rs-test, true)
• GitHub Check: standard-tests (ubuntu-latest, rainix-sol-artifacts)
• GitHub Check: standard-tests (ubuntu-latest, rainix-rs-artifacts, true)
• GitHub Check: test
• GitHub Check: build-tauri (ubuntu-22.04, true)
• GitHub Check: test
• GitHub Check: git-clean
• GitHub Check: Deploy-Preview
• GitHub Check: test

🔇 Additional comments (7)

crates/common/src/meta.rs (7)

48-53: Well-structured test module declaration.

The test module is appropriately declared with #[cfg(test)] and includes necessary imports. Good practice to bring in parent module items with super::*.

---

54-68: Good test data setup with clear constants.

The test data is well-defined with meaningful constant names. Having both the raw Rainlang source and its encoded metadata representation makes the tests self-explanatory and maintainable.

---

70-75: Effective happy path test.

This test properly verifies the successful decoding scenario, confirming that the method can correctly extract the original Rainlang source from encoded metadata.

---

77-85: Good error case testing for missing magic prefix.

This test properly validates the error handling for empty input, confirming that the method correctly identifies when the magic prefix is missing.

---

87-95: Thorough validation of hex decoding errors.

This test ensures that invalid hex input is properly handled, correctly asserting both the error type and specific variant (OddLength).

---

97-106: Comprehensive corrupt metadata error handling.

This test verifies that the method correctly handles corrupt but seemingly valid metadata by checking for the appropriate error type and message.

---

48-107: Complete test coverage of error paths.

The test suite provides excellent coverage for the try_decode_rainlangsource method, testing both the happy path and all error conditions. The tests are well-structured, focused, and follow good Rust testing practices.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.