Add tests for add order file

[findolor]

Motivation

See issue: #1623

Solution

Checks

By submitting this for review, I'm confirming I've done the following:

• made this PR as small as possible
• unit-tested any new functionality
• linked any relevant issues or PRs
• [ ] included screenshots (if this involves a front-end change)

fix #1623

Summary by CodeRabbit

• Tests
  • Added new tests to verify rainlang parsing, rainlang string composition, and conversion of add order calls to transaction parameters. These enhancements provide improved test coverage for order-related functionality.

[coderabbitai]

Walkthrough

This change adds several new asynchronous test functions to the test module of crates/common/src/add_order.rs. These tests focus on verifying the parsing of rainlang code, the composition of rainlang strings, and the conversion of add order calls into transaction parameters. The additions are limited to test code, with no modifications to the production logic or exported/public entities. The necessary imports are updated to support the new tests.

Changes

File(s)	Change Summary
crates/common/src/add_order.rs	Added multiple async test functions to the test module for rainlang parsing, rainlang composition, and transaction parameter conversion. Adjusted imports for testing.

Sequence Diagram(s)

sequenceDiagram
    participant Test as Test Function
    participant AddOrderArgs
    participant RainlangParser
    participant TransactionArgs

    Test->>AddOrderArgs: Create instance with test data
    Test->>AddOrderArgs: Call compose_to_rainlang()
    AddOrderArgs-->>Test: Return rainlang string

    Test->>RainlangParser: try_parse_rainlang(rainlang string)
    RainlangParser-->>Test: Return bytecode

    Test->>TransactionArgs: try_into_write_contract_parameters(addOrder2Call)
    TransactionArgs-->>Test: Return contract parameters

Loading

Assessment against linked issues

Objective	Addressed	Explanation
Test coverage for AddOrderArgs::execute and AddOrderArgs::get_add_order_calldata (#1623)	❌	The new tests do not cover execute or get_add_order_calldata.

Suggested reviewers

• hardyjosh

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e02197d and d481160.

📒 Files selected for processing (1)

• crates/common/src/add_order.rs (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (16)

• GitHub Check: standard-tests (ubuntu-latest, rainix-sol-legal)
• GitHub Check: standard-tests (ubuntu-latest, rainix-sol-static)
• GitHub Check: standard-tests (ubuntu-latest, rainix-rs-static)
• GitHub Check: standard-tests (ubuntu-latest, rainix-wasm-artifacts)
• GitHub Check: standard-tests (ubuntu-latest, ob-rs-test, true)
• GitHub Check: standard-tests (ubuntu-latest, test-js-bindings)
• GitHub Check: standard-tests (ubuntu-latest, rainix-sol-test)
• GitHub Check: standard-tests (ubuntu-latest, rainix-sol-artifacts)
• GitHub Check: standard-tests (ubuntu-latest, rainix-wasm-test)
• GitHub Check: standard-tests (ubuntu-latest, rainix-rs-artifacts, true)
• GitHub Check: test
• GitHub Check: Deploy-Preview
• GitHub Check: test
• GitHub Check: build-tauri (ubuntu-22.04, true)
• GitHub Check: test
• GitHub Check: git-clean

🔇 Additional comments (4)

crates/common/src/add_order.rs (4)

336-350: Appropriate imports added for the new test functions.

The necessary imports have been added to support the new test functions, including DotrainOrder, Bytes, default_document, FromStr, and additional sync utilities.

---

982-1099: Well-structured test for try_parse_rainlang functionality.

This test thoroughly verifies the try_parse_rainlang method by creating a realistic deployment environment and asserting the expected bytecode output. This improves coverage for a critical parsing function.

---

1101-1148: Good test for compose_to_rainlang method.

This test properly verifies that the compose_to_rainlang method correctly formats rainlang strings with the provided bindings. The assertion checks that entrypoints are properly formatted in the output string.

---

1150-1201: Comprehensive test for transaction parameter conversion.

This test properly verifies that TransactionArgs::try_into_write_contract_parameters correctly converts an addOrder2Call into write contract parameters while preserving all input values. This ensures that the transaction preparation process works correctly.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.