-
Notifications
You must be signed in to change notification settings - Fork 7
Test dropdown property #1726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test dropdown property #1726
Conversation
WalkthroughA new test file for the Changes
Sequence Diagram(s)sequenceDiagram
participant TestRunner
participant DropdownProperty
TestRunner->>DropdownProperty: Render with key and value props
DropdownProperty-->>TestRunner: Rendered output with key and value
TestRunner->>TestRunner: Assert key and value are present in output
TestRunner->>DropdownProperty: Render with key and empty value
DropdownProperty-->>TestRunner: Rendered output with key only
TestRunner->>TestRunner: Assert key is present in output
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
packages/ui-components/src/__tests__/DropdownProperty.test.ts
(1 hunks)
🔇 Additional comments (2)
packages/ui-components/src/__tests__/DropdownProperty.test.ts (2)
1-3
: Ensure jest-dom matchers are configured
The tests leveragetoBeInTheDocument()
, which requires jest-dom (or vitest-dom) matchers to be registered. Please verify your Vitest setup imports@testing-library/jest-dom
or uses thevitest-dom
plugin so that this matcher resolves correctly.
6-14
: Basic render test is clear and correct
This test accurately validates that the component renders the providedkey
andvalue
props. Good use of Svelte Testing Library.
Motivation
Solution
Checks
By submitting this for review, I'm confirming I've done the following:
Summary by CodeRabbit