Skip to content

Conversation

@findolor
Copy link
Collaborator

@findolor findolor commented Dec 11, 2025

Chained PR

Motivation

See issues:

Solution

  • Add a new module called take_orders to common crate
  • Add the logic to build order candidates for a given pair. This function fetches order codes and filters them based pair information and max output being greater than zero
  • Add tests

Checks

By submitting this for review, I'm confirming I've done the following:

  • made this PR as small as possible
  • unit-tested any new functionality
  • linked any relevant issues or PRs
  • included screenshots (if this involves a front-end change)

fix #2355

@findolor findolor requested review from 0xgleb and hardyjosh December 11, 2025 11:51
@findolor findolor self-assigned this Dec 11, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 11, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch 2025-12-11-take-orders-candidates

Comment @coderabbitai help to get the list of available commands and usage tips.

@findolor findolor changed the base branch from main to 2025-12-08-orders-token-filtering December 11, 2025 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants