Update tauri-release.yml #2361
Merged
Update tauri-release.yml #2361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
WalkthroughAdds a new "Forward CI Status" GitHub Actions step to many workflows that always runs and posts the job status to a Telegram chat via the rainlanguage/github-chore telegram-status-report action; also updates macOS matrix entries (macos-13 → macos-15-intel) and workspace cleanup in tauri workflows. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant GH as GitHub Actions Runner
participant Action as rainlanguage/github-chore Action
participant TG as Telegram API / Chat
GH->>Action: invoke telegram-status-report\ninputs: status=${{ job.status }}, token, chat_id
alt success
Action->>TG: POST message (job status)
TG-->>Action: 200 OK
Action-->>GH: step success
else failure/cancel
Action->>TG: POST message (job status: failure/cancelled)
TG-->>Action: 200 OK
Action-->>GH: step success (always runs)
end
note right of GH: Step runs with `if: always()` so executes after job completion
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used🧠 Learnings (1)📓 Common learnings⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (19)
Comment |
hardyjosh
approved these changes
Dec 23, 2025
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 25
📜 Review details
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (18)
.github/workflows/build-cli-binary.yaml.github/workflows/copilot-setup-steps.yml.github/workflows/deploy-subgraph.yaml.github/workflows/git-clean.yaml.github/workflows/manual-rs-release.yml.github/workflows/manual-sol-artifacts.yaml.github/workflows/npm-package-release.yml.github/workflows/rainix.yaml.github/workflows/tauri-release.yml.github/workflows/tauri.yaml.github/workflows/test-subgraph.yml.github/workflows/test-ui-components.yaml.github/workflows/test-webapp.yaml.github/workflows/vercel-docs-preview.yaml.github/workflows/vercel-docs-prod.yaml.github/workflows/vercel-preview-pr-target.yaml.github/workflows/vercel-preview.yaml.github/workflows/vercel-prod.yaml
🧰 Additional context used
🧠 Learnings (12)
📓 Common learnings
Learnt from: rouzwelt
Repo: rainlanguage/rain.orderbook PR: 0
File: :0-0
Timestamp: 2025-05-21T22:14:22.646Z
Learning: For PR #1884 in rainlanguage/rain.orderbook, I must consistently report the PR size after EVERY new commit in the exact format "TOTAL=number\nADDITIONS=number\nDELETIONS=number" without any additional text or formatting blocks. The report must exclude lock files (package-lock.json, yarn.lock, pnpm-lock.yaml, cargo.lock) and can be included either as part of the review or as a separate comment.
Learnt from: brusherru
Repo: rainlanguage/rain.orderbook PR: 2044
File: tauri-app/src/routes/orders/[chainId]-[orderbook]-[orderHash]/+page.svelte:76-78
Timestamp: 2025-07-31T19:03:56.594Z
Learning: In the rainlanguage/rain.orderbook project, when the Tauri app has issues preventing proper testing, the team prefers to defer Tauri-specific implementations to separate PRs rather than including untested code, especially for financial operations like withdrawals.
Learnt from: rouzwelt
Repo: rainlanguage/rain.orderbook PR: 0
File: :0-0
Timestamp: 2025-05-21T22:14:22.646Z
Learning: For PR #1884 in rainlanguage/rain.orderbook, I must consistently report the PR size after EVERY new commit in the exact format "TOTAL=number\nADDITIONS=number\nDELETIONS=number" without any formatting blocks. The report must exclude lock files (package-lock.json, yarn.lock, pnpm-lock.yaml, cargo.lock) and can be included either as part of the review or as a separate comment.
Learnt from: rouzwelt
Repo: rainlanguage/rain.orderbook PR: 0
File: :0-0
Timestamp: 2025-05-21T21:26:31.566Z
Learning: For PR #1884 and future PRs in rainlanguage/rain.orderbook repository, provide PR size reports in a separate comment with ONLY the exact format "TOTAL=number\nADDITIONS=number\nDELETIONS=number", without any additional text or explanation. Reports should exclude irrelevant files such as lock files (package-lock.json, yarn.lock, pnpm-lock.yaml, cargo.lock).
Learnt from: rouzwelt
Repo: rainlanguage/rain.orderbook PR: 0
File: :0-0
Timestamp: 2025-05-21T22:46:08.530Z
Learning: For PR #1884 in rainlanguage/rain.orderbook, the PR size report should be the only content in the comment - no text before it, no text after it, no formatting blocks, just the raw report in the exact format: "TOTAL=number\nADDITIONS=number\nDELETIONS=number". The report must exclude lock files (package-lock.json, yarn.lock, pnpm-lock.yaml, cargo.lock).
Learnt from: rouzwelt
Repo: rainlanguage/rain.orderbook PR: 0
File: :0-0
Timestamp: 2025-05-21T23:34:42.328Z
Learning: For PR #1884 in rainlanguage/rain.orderbook, the PR size report must use the format:
TOTAL:number
ADDITIONS:number
DELETIONS:number
with no extra text, formatting blocks, or explanations, and must still exclude lock files and reassess after each new commit.
Learnt from: rouzwelt
Repo: rainlanguage/rain.orderbook PR: 0
File: :0-0
Timestamp: 2025-05-21T23:09:27.578Z
Learning: For PR #1884 in rainlanguage/rain.orderbook repository, I must always reassess the PR size after each new commit, calculating the total changes up to the very latest commit and ensuring accuracy of the report. The calculation must exclude lock files (package-lock.json, yarn.lock, pnpm-lock.yaml, cargo.lock) and report in the exact format "TOTAL=number\nADDITIONS=number\nDELETIONS=number".
Learnt from: rouzwelt
Repo: rainlanguage/rain.orderbook PR: 0
File: :0-0
Timestamp: 2025-05-21T21:24:53.708Z
Learning: For PR #1884 in rainlanguage/rain.orderbook, provide a separate comment after each review with PR size statistics in the format: `TOTAL=number ADDITIONS=number DELETIONS=number`, excluding lock files like package-lock.json and cargo.lock.
Learnt from: rouzwelt
Repo: rainlanguage/rain.orderbook PR: 0
File: :0-0
Timestamp: 2025-05-21T21:24:53.708Z
Learning: For PR #1884 in rainlanguage/rain.orderbook, provide a separate comment after each review with PR size statistics in the format: `TOTAL=number ADDITIONS=number DELETIONS=number`, excluding lock files like package-lock.json and cargo.lock.
Learnt from: rouzwelt
Repo: rainlanguage/rain.orderbook PR: 0
File: :0-0
Timestamp: 2025-05-21T21:24:53.708Z
Learning: For PR #1884 in rainlanguage/rain.orderbook, provide a separate comment after each review with PR size statistics in the format: `TOTAL=number ADDITIONS=number DELETIONS=number`, excluding lock files like package-lock.json and cargo.lock.
📚 Learning: 2025-11-25T16:50:11.197Z
Learnt from: CR
Repo: rainlanguage/rain.orderbook PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-25T16:50:11.197Z
Learning: Always run commands via Nix: `nix develop -c <command>`. Never cancel long-running tasks (45–90 min builds, 30+ min tests).
Applied to files:
.github/workflows/manual-rs-release.yml.github/workflows/tauri-release.yml.github/workflows/test-subgraph.yml.github/workflows/deploy-subgraph.yaml
📚 Learning: 2025-11-25T16:50:11.197Z
Learnt from: CR
Repo: rainlanguage/rain.orderbook PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-25T16:50:11.197Z
Learning: Before pushing, do a quick verification by running: `nix develop -c npm run lint-format-check:all`, `nix develop -c npm run test`, and `nix develop -c cargo test --workspace`
Applied to files:
.github/workflows/manual-rs-release.yml.github/workflows/tauri-release.yml
📚 Learning: 2025-11-25T16:50:11.197Z
Learnt from: CR
Repo: rainlanguage/rain.orderbook PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-25T16:50:11.197Z
Learning: Before the final commit of the session, fully mirror CI by running: `./prep-all.sh`, `nix develop -c npm run lint-format-check:all`, `nix develop -c npm run build:orderbook`, `nix develop -c npm run build:ui`, `nix develop -c cargo test --workspace`, `nix develop -c npm run test`, and `nix develop -c forge test`
Applied to files:
.github/workflows/manual-rs-release.yml.github/workflows/tauri-release.yml.github/workflows/test-subgraph.yml.github/workflows/deploy-subgraph.yaml
📚 Learning: 2025-11-25T16:50:31.752Z
Learnt from: CR
Repo: rainlanguage/rain.orderbook PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-11-25T16:50:31.752Z
Learning: Quick preflight check: run `nix develop -c npm run lint-format-check:all && nix develop -c rainix-rs-static` before submitting
Applied to files:
.github/workflows/manual-rs-release.yml.github/workflows/tauri-release.yml
📚 Learning: 2025-11-25T16:50:31.752Z
Learnt from: CR
Repo: rainlanguage/rain.orderbook PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-11-25T16:50:31.752Z
Learning: Run every command through `nix develop -c <cmd>`; avoid entering an interactive Nix shell
Applied to files:
.github/workflows/tauri-release.yml
📚 Learning: 2025-11-25T16:50:11.197Z
Learnt from: CR
Repo: rainlanguage/rain.orderbook PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-25T16:50:11.197Z
Learning: Applies to packages/webapp/**/*.{svelte,ts,tsx,js,jsx} : For Webapp (`packages/webapp`), run lints and format checks using `nix develop -c npm run svelte-lint-format-check -w rainlanguage/webapp`
Applied to files:
.github/workflows/tauri-release.yml
📚 Learning: 2025-11-25T16:50:11.197Z
Learnt from: CR
Repo: rainlanguage/rain.orderbook PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-25T16:50:11.197Z
Learning: Applies to packages/webapp/**/*.{ts,tsx,js,jsx} : For Webapp (`packages/webapp`), run tests using `nix develop -c npm run test -w rainlanguage/webapp`
Applied to files:
.github/workflows/tauri-release.yml
📚 Learning: 2025-11-25T16:50:31.752Z
Learnt from: CR
Repo: rainlanguage/rain.orderbook PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-11-25T16:50:31.752Z
Learning: Applies to **/*.{ts,tsx,svelte} : TypeScript/Svelte: lint with `nix develop -c npm run lint`
Applied to files:
.github/workflows/tauri-release.yml
📚 Learning: 2025-11-25T16:50:11.197Z
Learnt from: CR
Repo: rainlanguage/rain.orderbook PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-25T16:50:11.197Z
Learning: Applies to packages/ui-components/**/*.{svelte,ts,tsx,js,jsx} : For UI components (`packages/ui-components`), run lints and format checks using `nix develop -c npm run svelte-lint-format-check -w rainlanguage/ui-components`
Applied to files:
.github/workflows/tauri-release.yml
📚 Learning: 2025-11-25T16:50:31.752Z
Learnt from: CR
Repo: rainlanguage/rain.orderbook PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-11-25T16:50:31.752Z
Learning: Applies to **/*.{ts,tsx,svelte} : TypeScript/Svelte: type-check with `nix develop -c npm run check`
Applied to files:
.github/workflows/tauri-release.yml
📚 Learning: 2025-07-11T12:29:49.284Z
Learnt from: findolor
Repo: rainlanguage/rain.orderbook PR: 1971
File: .github/workflows/vercel-docs-prod.yaml:10-14
Timestamp: 2025-07-11T12:29:49.284Z
Learning: In GitHub Actions workflows for the rainlanguage/rain.orderbook project, findolor is comfortable with job names that may seem misleading (like "Deploy-Docs-Preview" in a production workflow) when there's only one job in the workflow, as the context makes it clear enough.
Applied to files:
.github/workflows/vercel-docs-prod.yaml.github/workflows/vercel-docs-preview.yaml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (19)
- GitHub Check: git-clean
- GitHub Check: test
- GitHub Check: test
- GitHub Check: copilot-setup-steps
- GitHub Check: standard-tests (ubuntu-latest, test-js-bindings)
- GitHub Check: standard-tests (ubuntu-latest, rainix-sol-legal)
- GitHub Check: standard-tests (ubuntu-latest, rainix-wasm-artifacts)
- GitHub Check: standard-tests (ubuntu-latest, rainix-sol-artifacts)
- GitHub Check: standard-tests (ubuntu-latest, rainix-wasm-test)
- GitHub Check: standard-tests (ubuntu-latest, ob-rs-test, true)
- GitHub Check: standard-tests (ubuntu-latest, rainix-rs-artifacts, true)
- GitHub Check: standard-tests (ubuntu-latest, rainix-sol-static)
- GitHub Check: standard-tests (ubuntu-latest, rainix-wasm-browser-test)
- GitHub Check: standard-tests (ubuntu-latest, rainix-sol-test)
- GitHub Check: standard-tests (ubuntu-latest, rainix-rs-static)
- GitHub Check: test
- GitHub Check: build-tauri (ubuntu-22.04, true)
- GitHub Check: Deploy-Preview-Push
- GitHub Check: Deploy-Docs-Preview
🔇 Additional comments (9)
.github/workflows/vercel-preview.yaml (2)
102-110: Verify alignment with security model.This file has explicit security warnings (lines 1-16) about secrets handling. The new step passes
TELEGRAM_BOT_TOKENandTELEGRAM_CHAT_IDsecrets to an external action.While this follows a similar pattern to the Vercel CLI steps (secrets only to specific trusted steps, not build/test), ensure that:
- The
rainlanguage/github-choreaction is trusted and maintained by your organization- Adding this notification mechanism doesn't violate the documented security invariants
106-106: Consider pinning the action to a specific version.Using
@mainreferences a floating branch that can change unexpectedly, which may introduce breaking changes or security risks. This is especially important in a workflow with explicit security hardening (PATH hijacking prevention, shell hardening, etc.). Consider pinning to a specific commit SHA or tagged release.⛔ Skipped due to learnings
Learnt from: findolor Repo: rainlanguage/rain.orderbook PR: 1971 File: .github/workflows/vercel-docs-prod.yaml:32-34 Timestamp: 2025-07-11T12:30:09.245Z Learning: findolor prefers not to pin Node versions explicitly in GitHub Actions workflows when using Nix with webapp-shell, considering the current setup sufficient for deterministic builds in the rainlanguage/rain.orderbook project..github/workflows/tauri-release.yml (4)
44-44: LGTM: Disk cleanup condition updated correctly.The condition now properly includes
macos-15-intelalongsidemacos-14for the disk cleanup step.
111-111: LGTM: Good practice to clean up environment files.Removing
tauri-app/.envbefore the release build ensures a clean state and prevents potential secrets leakage in build artifacts.
155-162: LGTM: CI status forwarding implementation is correct for this workflow.The comment "only runs for default branch" is accurate because the job has a condition at line 12 that enforces
github.ref == 'refs/heads/main'. Theif: always()ensures notifications are sent regardless of job outcome.
20-20: The platform is already in use in the activetauri.yamlworkflow with the same Tauri version (1.5) and disk cleanup configuration. No compatibility issues exist—the change is consistent with existing CI/CD infrastructure..github/workflows/tauri.yaml (2)
19-19: Verify compatibility with macOS 15 Intel runners.The platform has been updated from
macos-13tomacos-15-intel. This is a duplicate concern from tauri-release.yml - ensure compatibility across both workflows.The matrix excludes
macos-15-intelfor non-main branches (line 24), which is efficient for resource usage.
48-48: LGTM: Disk cleanup condition updated correctly.Matches the change in tauri-release.yml for consistency.
.github/workflows/vercel-docs-prod.yaml (1)
49-56: LGTM: CI status forwarding implementation is correct.The workflow correctly triggers only on the main branch (line 8), and the
if: always()condition ensures notifications are sent regardless of job outcome.
Contributor
|
@coderabbitai assess this PR size classification for the totality of the PR with the following criterias and report it in your comment: S/M/L PR Classification Guidelines:This guide helps classify merged pull requests by effort and complexity rather than just line count. The goal is to assess the difficulty and scope of changes after they have been completed. Small (S)Characteristics:
Review Effort: Would have taken 5-10 minutes Examples:
Medium (M)Characteristics:
Review Effort: Would have taken 15-30 minutes Examples:
Large (L)Characteristics:
Review Effort: Would have taken 45+ minutes Examples:
Additional Factors to ConsiderWhen deciding between sizes, also consider:
Notes:
|
Contributor
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: Length of output: 1810 SIZE=M 🧠 Learnings used |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Solution
Checks
By submitting this for review, I'm confirming I've done the following:
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.