Example pull request #36
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Author
|
Thank you for your contribution! 🎉 We will review your pull request and get back to you as soon as possible. |
Owner
Author
|
Hi @rainsworth, this is really valuable 👍 I just have a few suggestions for minor changes before we merge this into the
|
Owner
Author
|
Thanks @rainsworth, I have now made those changes and also removed some text because of a reason. |
Owner
Author
|
Brilliant, I will go ahead and merge this now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds an example markdown file and will serve as an example pull request for the demonstration.
Pull requests are proposed changes to a repository submitted by a user and accepted or rejected by a repository's owner (or designated collaborators). Like issues, pull requests each have their own discussion forum.
It’s important to provide as much useful information and a rationale for why you’re making this pull request in the first place. The project owner needs to be able to determine whether your change is as useful to everyone as you think it is.
It's helpful to summarise the changes in a list:
You can also tag related issues using a hashtag: #18 or link to them in the right sidebar.