feat(builder): add skipGenerateIfCached parameter to CMakeBuilder #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new optional parameter `skipGenerateIfCached` to the `CMakeBuilder.run` method. When set to `true`, the builder will skip the CMake generation step if a valid CMakeCache.txt exists and the last generation was successful, improving build performance for repeated builds. The last generation status is persisted to a file in the output directory to track success. Add a corresponding unit test to verify the caching behavior.
The previous logic incorrectly skipped generation when skipGenerateIfCached was false. The condition was inverted, causing generation to be skipped when it should run. Now properly track skip state and only skip when both conditions are met.
The condition was inverted, causing generation to be skipped when it should run and vice versa. This prevented CMake projects from being generated when needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #25
Add a new optional parameter
skipGenerateIfCachedto theCMakeBuilder.runmethod. When set totrue, the builder will skip the CMake generation step if a valid CMakeCache.txt exists and the last generation was successful, improving build performance for repeated builds. The last generation status is persisted to a file in the output directory to track success.Add a corresponding unit test to verify the caching behavior.